1708251 - Wrong highlighted text on search in PDF

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Brendan Dahl [:bdahl]]

For STR see:
https://github.com/mozilla/pdf.js/issues/13292#issue-866739981

Comment 1

[Brendan Dahl [:bdahl]]

[Tracking Requested - why for this release]:
Visible regression for the PDF viewer.

Comment 2

[Brendan Dahl [:bdahl]]

Attachment: Bug 1708251 - Fix position of highlighted all text. r=calixte

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1704661

Comment 4

[Brendan Dahl [:bdahl]]

Comment on attachment 9218991 [details]
Bug 1708251 - Fix position of highlighted all text. r=calixte

Beta/Release Uplift Approval Request

• User impact if declined: When using "highlight all" in the find bar, not all the text will be highlighted in the correct position.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://github.com/mozilla/pdf.js/issues/13292#issue-866739981
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small CSS change.
• String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

AIUI this was fixed in 90 by bug 1708241?

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Julien Cristau [:jcristau] from comment #5)

AIUI this was fixed in 90 by bug 1708241?

Correct!

Comment 7

[Camelia Badau [:cbadau], Desktop QA]

Reproduced the issue on Firefox 89 Beta 5.
Verified fixed on latest Nightly 90.0a1 (buildID: 20210505215208) on Windows 10 x64, Ubuntu 18.04 and macOS 11.2.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9218991 [details]
Bug 1708251 - Fix position of highlighted all text. r=calixte

Fix baked on nightly for a week, let's take it in 89 beta 10, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c7f58663b63

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Firefox 89 Beta 10 on Windows 10 x64, Ubuntu 18.04 and macOS 11.3.