1708329 - Update more of the icons in browser/themes/shared (fullscreen, customize, import, login, back, warning)

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

/browser/themes/shared/icons/back-12.svg
** Go to a page where Tracking Protection blocks some content. Open the Tracking Protection panel, and you will see this icon appear at the end of the categories as an arrow.

/browser/themes/shared/icons/customize.svg
** Open Customize mode, and you will see this icon as the tab's favicon

/browser/themes/shared/icons/fullscreen-exit.svg
** Open the browser menu, and you will see this icon in the Zoom controls section when in fullscreen

/browser/themes/shared/icons/fullscreen.svg
** Open the browser menu, and you will see this icon in the Zoom controls section when not in fullscreen

/browser/themes/shared/icons/import.svg
** Open about:logins and open the menu, look at the Import menuitem

/browser/themes/shared/icons/login.svg
** Go to a website that has a login form and attempt to login, the panel that opens and offers to save the login will have the updated icon as the anchor in the address bar

/browser/themes/shared/warning.svg
** Go to about:logins, create a login, then attempt to remove the login. This icon will be the icon in the warning dialog

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1708329 - Update more of the icons in /browser/themes/shared for Proton.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3784de5b0db5
Update more of the icons in /browser/themes/shared for Proton. r=sfoster

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9219099 [details]
Bug 1708329 - Update more of the icons in /browser/themes/shared for Proton.

Beta/Release Uplift Approval Request

• User impact if declined: Required for Proton/MR1
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1708329#c0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Icon-only change
• String changes made/needed: none

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3784de5b0db5

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9219099 [details]
Bug 1708329 - Update more of the icons in /browser/themes/shared for Proton.

Approved for 89 beta 7, thanks.

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6a01867cf07

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that all the icons in Comment 0 were implemented successfully and working as expected on Firefox 89.0b8 and Firefox 90.0a1 (2021-05-05). Tests were performed under macOS 10.15.7, Windows 10 and Ubuntu 20.04.