1708368 - Firefox hangs if Overflow menu is closed from the button while Import your login is displayed

Status: NEW

(Toolkit :: Password Manager, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: fxhang.gif

Affected versions

• 90.0a1(20210428215523)
• 89.0b5 (20210427185821)
• 88.0 (20210415204500)

Affected platforms

• Windows10 x64

Steps to reproduce

1. Open Firefox with a new profile and add some items to the overflow menu.
2. Open Facebook and focus the username field.
3. Open the overflow menu and type a from the keyboard.
4. Close the Overflow menu by pressing the overflow button on the toolbar.

Expected result

• Overflow menu is closed.

Actual result

• Firefox hangs.

Regression range

• I will search for one ASAP if there is one.

Notes

• Attached a screen recording.
• On macOS 10.15 the overflow menu flashes but no hang with the above str.

Comment 1

[:Gijs (out for now; he/him)]

Does this reproduce in 78 esr if you enable signon.showAutoCompleteImport by setting that pref to import ? If not, a regression window would be very very helpful.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I ran this through mozregression and got this range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=55f5d719d0359a35443d0d2586af7383645a94b6&tochange=15ffd69c83be752a28fc40a5db6b6859452fa41f

My guess is that https://hg.mozilla.org/mozilla-central/rev/714d667c7f120e7218ca08fb0f29508f4c81cc92 caused this.

This was my command for mozregression, mach mozregression -g 60 --pref signon.showAutoCompleteImport:import -a "https://www.facebook.com"

In the STR, you will need to have a login stored that will appear in the autocomplete popup.

Adjusted STR:

1. Open Firefox with a new profile and add some items to the overflow menu.
2. Open Facebook and focus the username field.
3. Attempt to login with username 'a' and password 'a'.
4. Once login is rejected, hit Back button return to login form.
5. Open the overflow menu and type 'a' from the keyboard.
6. Close the Overflow menu by pressing the overflow button on the toolbar.
7. Click on the webpage
8. Click on the Overflow menu (these last two steps are needed because the 'open' state of the Overflow button persists, a separate bug that was introduced prior to this bug)

Comment 3

[Sam Foster [:sfoster] (he/him)]

It would be good to understand if this is a bug in the autocomplete menu & new import item, or due to changes in the overflow menu. From past experience I would suspect the autocomplete menu?