1708511 - Rename glyph-modal-delete-32.svg to match its actual size

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P2)

Description

[Bernard Igiri]

The file:
browser/components/newtab/data/content/assets/glyph-star-17.svg

Needs to be renamed to:
browser/components/newtab/data/content/assets/glyph-star-16.svg

Due to changes made in Bug 1703027

Comment 1

[Tim Nguyen :ntim]

There's more misnamed icons in https://phabricator.services.mozilla.com/D113687 (e.g. the ones with 24/32 in the name).

Comment 2

[Falguni Islam]

Hello I am an accepted outreachy applicant I am looking for good first bug can I work on this bug?

Comment 3

[gloriaeskor]

Hi, I am an outreachy applicant. I am trying to work on this but I can't find the glyph-star-17

Comment 4

[Amy Churchwell [:amy]]

It looks like a lot of the icons have been removed since this was filed.

There's more misnamed icons in https://phabricator.services.mozilla.com/D113687 (e.g. the ones with 24/32 in the name).

The only remaining file like this is browser/components/newtab/data/content/assets/glyph-modal-delete-32.svg, should this be renamed or is this bug no longer valid?

Comment 5

[Favour Abangwu]

Attachment: Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8

The bug was initially about renaming glyph-star-17.svg to match new resolution but the file was missing. There was an additional comment that requested that other misnamed icons should be looked into. The only file that was left to be renamed was the glyph-modal-delete-32.svg.

Comment 6

[Bernard Igiri]

I don't know about the files ending in 32, but if glyph-star-17.svg is gone then it no longer needs to be renamed. If you need more information I would suggest asking Sam Foster.

Comment 7

[Sam Foster [:sfoster] (he/him)]

Yeah glyph-modal-delete-32.svg is actually 20x20, so I don't think it would hurt to fix that. I've updated the bug summary so we can reuse this bug and not lose comment history.

I'd suggest glyph-modal-delete-32.svg be renamed to glyph-modal-delete-20.svg.

Comment 8

[Favour Abangwu]

Attachment: Bug 1708511 reverting formatting and removing css changes r?amy

I followed your instructions.

Depends on D130124

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[samuraix221]

Hi has this been fixed or can I be assigned to this I just got accepted to the Outreachy program and I'm excited to contribute to fixing a firefox issue.

Comment 11

[Sam Foster [:sfoster] (he/him)]

This still needs fixing, and comment #7 is still applicable. The filename implies the image is 32px in size, but the actual size is 20. Your patch will need to rename the file (please use hg mv) and find all instances of this filename to correct them to the new file.

:dharvey - do you want to mentor this one, or should I? Feel free to update the bug either way.

Comment 12

[Sam Foster [:sfoster] (he/him)]

samuraix221, I've assigned you to avoid confusion. But please only pick up bugs you are actively working on as these good-first-bugs become a valuable commodity in Outreachy season and we want to ensure everyone has an opportunity to contribute.

Comment 13

[samuraix221]

(In reply to Sam Foster [:sfoster] (he/him) from comment #12)

samuraix221, I've assigned you to avoid confusion. But please only pick up bugs you are actively working on as these good-first-bugs become a valuable commodity in Outreachy season and we want to ensure everyone has an opportunity to contribute.

Hi Sam, thank you ill work on it can I get some mentoring assistance?

Comment 14

[Sam Foster [:sfoster] (he/him)]

(In reply to samuraix221 from comment #13)

Hi Sam, thank you ill work on it can I get some mentoring assistance?

Sure, please don't ask to ask, just ask :) What kind of assistance you do need? If you have questions about building firefox or getting your patch together and posted for review, the #introduction matrix channel is your best bet. If you have specific questions about this particular bug, you can post those here.

Comment 15

[samuraix221]

Attachment: Bug 1708511 Rename glyph-modal-delete32.sv to match actual size. r?sfoster

file name changed in:
browser/components/newtab/data/content/assets/
browser/components/newtab/content-src/styles/_icons.scss
browser/components/newtab/css/activity-stream-mac.css
browser/components/newtab/css/activity-stream-linux.css
browser/components/newtab/css/activity-stream-windows.css
obj-aarch64-apple-darwin20.6.0/faster/install_dist_bin_browser.track

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3227a9eac5f
Rename glyph-modal-delete32.sv to match actual size. r=amy

Comment 17

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c3227a9eac5f

Comment 18

[Dale Harvey (:daleharvey)]

Clearing needinfo, landed