Closed Bug 1708511 Opened 1 year ago Closed 2 months ago

Rename glyph-modal-delete-32.svg to match its actual size

Categories

(Firefox :: New Tab Page, task, P2)

task

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: bigiri, Assigned: samuraix221)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 1 obsolete file)

The file:
browser/components/newtab/data/content/assets/glyph-star-17.svg

Needs to be renamed to:
browser/components/newtab/data/content/assets/glyph-star-16.svg

Due to changes made in Bug 1703027

There's more misnamed icons in https://phabricator.services.mozilla.com/D113687 (e.g. the ones with 24/32 in the name).

Mentor: achurchwell
Keywords: good-first-bug
Priority: -- → P2

Hello I am an accepted outreachy applicant I am looking for good first bug can I work on this bug?

Hi, I am an outreachy applicant. I am trying to work on this but I can't find the glyph-star-17

It looks like a lot of the icons have been removed since this was filed.

There's more misnamed icons in https://phabricator.services.mozilla.com/D113687 (e.g. the ones with 24/32 in the name).

The only remaining file like this is browser/components/newtab/data/content/assets/glyph-modal-delete-32.svg, should this be renamed or is this bug no longer valid?

Flags: needinfo?(bigiri)

The bug was initially about renaming glyph-star-17.svg to match new resolution but the file was missing. There was an additional comment that requested that other misnamed icons should be looked into. The only file that was left to be renamed was the glyph-modal-delete-32.svg.

Assignee: nobody → favourprecious3
Status: NEW → ASSIGNED
Attachment #9248773 - Attachment description: Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8 → Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r=standard8,amy
Attachment #9248773 - Attachment description: Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r=standard8,amy → Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8,amy

I don't know about the files ending in 32, but if glyph-star-17.svg is gone then it no longer needs to be renamed. If you need more information I would suggest asking Sam Foster.

Flags: needinfo?(bigiri) → needinfo?(sfoster)

Yeah glyph-modal-delete-32.svg is actually 20x20, so I don't think it would hurt to fix that. I've updated the bug summary so we can reuse this bug and not lose comment history.

I'd suggest glyph-modal-delete-32.svg be renamed to glyph-modal-delete-20.svg.

Flags: needinfo?(sfoster)
Summary: Rename glyph-star-17.svg to match new resolution → Rename glyph-modal-delete-32.svg to match its actual size
Attachment #9248773 - Attachment description: Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8,amy → Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8
Attachment #9248773 - Attachment description: Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8 → Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?amy

I followed your instructions.

Depends on D130124

Attachment #9248773 - Attachment description: Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?amy → Bug 1708511 I renamed the glyph-modal-delete-32.svg to glyph-modal-delete-20.svg r?standard8

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: favourprecious3 → nobody
Status: ASSIGNED → NEW
Mentor: achurchwell

Hi has this been fixed or can I be assigned to this I just got accepted to the Outreachy program and I'm excited to contribute to fixing a firefox issue.

Flags: needinfo?(dharvey)

This still needs fixing, and comment #7 is still applicable. The filename implies the image is 32px in size, but the actual size is 20. Your patch will need to rename the file (please use hg mv) and find all instances of this filename to correct them to the new file.

:dharvey - do you want to mentor this one, or should I? Feel free to update the bug either way.

samuraix221, I've assigned you to avoid confusion. But please only pick up bugs you are actively working on as these good-first-bugs become a valuable commodity in Outreachy season and we want to ensure everyone has an opportunity to contribute.

Assignee: nobody → samuraix221
Status: NEW → ASSIGNED

(In reply to Sam Foster [:sfoster] (he/him) from comment #12)

samuraix221, I've assigned you to avoid confusion. But please only pick up bugs you are actively working on as these good-first-bugs become a valuable commodity in Outreachy season and we want to ensure everyone has an opportunity to contribute.

Hi Sam, thank you ill work on it can I get some mentoring assistance?

(In reply to samuraix221 from comment #13)

Hi Sam, thank you ill work on it can I get some mentoring assistance?

Sure, please don't ask to ask, just ask :) What kind of assistance you do need? If you have questions about building firefox or getting your patch together and posted for review, the #introduction matrix channel is your best bet. If you have specific questions about this particular bug, you can post those here.

Attachment #9249179 - Attachment is obsolete: true

file name changed in:
browser/components/newtab/data/content/assets/
browser/components/newtab/content-src/styles/_icons.scss
browser/components/newtab/css/activity-stream-mac.css
browser/components/newtab/css/activity-stream-linux.css
browser/components/newtab/css/activity-stream-windows.css
obj-aarch64-apple-darwin20.6.0/faster/install_dist_bin_browser.track

Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3227a9eac5f
Rename glyph-modal-delete32.sv to match actual size. r=amy
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

Clearing needinfo, landed

Flags: needinfo?(dharvey)
You need to log in before you can comment on or make changes to this bug.