1708635 - Implement TargetCommand.reloadTopLevelTarget (to replace TargetFront.reload)

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

With bug 1698891, page reload are slightly more complex because "navigate" is no longer reliable and you should use DOCUMENT_EVENT's navigate instead.
Also, it would be nice to avoid using the target front directly to reload and instead go through a command, which would bundle the necessary additional code to wait for the completion of the navigation.
We can't do the wait from the TargetFront's reload method because we have to use the resourceWatcher, which can't be used from Fronts.

Unfortunately, to do that, we have to first convert ResourceWatcher to a command so that it can easily be used by any other command (bug 1701790).

Doing this will fix many test failure appearing in tests reloading page and listening to navigate. Especially netmonitor and accessibility panels. This may fix a couple of tests currently failing with bfcacheInParent.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1708635 - [devtools] Implement TargetCommand.reloadTopLevelTarget.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1708635 - [devtools] Migrate usages of TargetFront.reload to TargetCommand.reloadTopLevelTarget.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f15acee46be2
Implement TargetCommand.reloadTopLevelTarget. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6bce4e61777b
Migrate usages of TargetFront.reload to TargetCommand.reloadTopLevelTarget. r=nchevobbe

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures in devtools/client/responsive/test/browser/browser_device_change.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7ae39cd2f4f27cd0bfec2a1c56b78dcfdc7dd04d

Push with failures

Failure log

Comment 6

[Alexandre Poirot [:ochameau]]

I'm getting race condition when calling ResourceCommand.watchRestouces/unwatchResources.
Unfortunately, that's not super trivial to fix and would probably require some dedicated bug/patches against ResourceCommand.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4119bb33c63
[devtools] Implement TargetCommand.reloadTopLevelTarget. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cbb08db12151
[devtools] Migrate usages of TargetFront.reload to TargetCommand.reloadTopLevelTarget. r=nchevobbe

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f4119bb33c63
https://hg.mozilla.org/mozilla-central/rev/cbb08db12151