1708788 - Update toolkit/themes/shared/extensions/extensionGeneric.svg

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Harry Twyford]

toolkit/themes/shared/extensions/extensionGeneric.svg is used when we don't have an icon for an add-on. It's also used on AMO, so we should coordinate with the AMO team to get https://addons.cdn.mozilla.net/static/img/addon-icons/default-*.png replaced as well.

Comment 1

[Harry Twyford]

Attachment: Bug 1708788 - Update remaining extension icons. r?rpl!,mconley

Comment 2

[Harry Twyford]

The new icon is 16px and is replacing 32px and 64px versions. I discussed this with mixedpuppy and we determined this was okay. See bug 1708008 comment 4 for a list of everywhere these icons are used.

Comment 3

[Harry Twyford]

[Tracking Requested - why for this release]:
Proton icons.

I'll uplift tomorrow after verifying in Nightly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c9515b42d9c
Update remaining extension icons. r=mixedpuppy

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0c9515b42d9c

Comment 6

[Harry Twyford]

Comment on attachment 9219602 [details]
Bug 1708788 - Update remaining extension icons. r?rpl!,mconley

Beta/Release Uplift Approval Request

• User impact if declined: Proton icons will be missing.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changes contents of two icon SVGs.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9219602 [details]
Bug 1708788 - Update remaining extension icons. r?rpl!,mconley

Low risk, approved for 89 beta 8, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ba4d7ccf030