Update toolkit/themes/shared/extensions/extensionGeneric.svg
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-icons] [proton-uplift])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
toolkit/themes/shared/extensions/extensionGeneric.svg
is used when we don't have an icon for an add-on. It's also used on AMO, so we should coordinate with the AMO team to get https://addons.cdn.mozilla.net/static/img/addon-icons/default-*.png
replaced as well.
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
The new icon is 16px and is replacing 32px and 64px versions. I discussed this with mixedpuppy and we determined this was okay. See bug 1708008 comment 4 for a list of everywhere these icons are used.
Assignee | ||
Comment 3•2 years ago
|
||
[Tracking Requested - why for this release]:
Proton icons.
I'll uplift tomorrow after verifying in Nightly.
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c9515b42d9c Update remaining extension icons. r=mixedpuppy
Updated•2 years ago
|
Comment 5•2 years ago
|
||
bugherder |
Assignee | ||
Comment 6•2 years ago
|
||
Comment on attachment 9219602 [details]
Bug 1708788 - Update remaining extension icons. r?rpl!,mconley
Beta/Release Uplift Approval Request
- User impact if declined: Proton icons will be missing.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Changes contents of two icon SVGs.
- String changes made/needed:
Updated•2 years ago
|
Comment 7•2 years ago
|
||
Comment on attachment 9219602 [details]
Bug 1708788 - Update remaining extension icons. r?rpl!,mconley
Low risk, approved for 89 beta 8, thanks.
Comment 8•2 years ago
|
||
bugherder uplift |
Description
•