Closed Bug 1708788 Opened 7 months ago Closed 7 months ago

Update toolkit/themes/shared/extensions/extensionGeneric.svg

Categories

(Firefox :: Theme, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Status
firefox89 + fixed
firefox90 --- fixed

People

(Reporter: harry, Assigned: harry)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons] [proton-uplift])

Attachments

(1 file)

toolkit/themes/shared/extensions/extensionGeneric.svg is used when we don't have an icon for an add-on. It's also used on AMO, so we should coordinate with the AMO team to get https://addons.cdn.mozilla.net/static/img/addon-icons/default-*.png replaced as well.

Whiteboard: proton-icons] → [proton-icons]

The new icon is 16px and is replacing 32px and 64px versions. I discussed this with mixedpuppy and we determined this was okay. See bug 1708008 comment 4 for a list of everywhere these icons are used.

[Tracking Requested - why for this release]:
Proton icons.

I'll uplift tomorrow after verifying in Nightly.

Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c9515b42d9c
Update remaining extension icons. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9219602 [details]
Bug 1708788 - Update remaining extension icons. r?rpl!,mconley

Beta/Release Uplift Approval Request

  • User impact if declined: Proton icons will be missing.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes contents of two icon SVGs.
  • String changes made/needed:
Flags: needinfo?(htwyford)
Attachment #9219602 - Flags: approval-mozilla-beta?
Whiteboard: [proton-icons] → [proton-icons] [proton-uplift]

Comment on attachment 9219602 [details]
Bug 1708788 - Update remaining extension icons. r?rpl!,mconley

Low risk, approved for 89 beta 8, thanks.

Attachment #9219602 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.