1708960 - [Proton] Close button's hover state of the chiclet is too close to the chiclet text

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mehmet]

Attachment: actual_vs_expected.png

Nightly 90.0a1 (2021-05-01) (64-Bit)
MacOS

1.) Take a look at the close button's hover state

Actual: It is too close to the text.

Expected: There could be a few pixels more padding between text and button to breathe :)

Not sure if this is a recent regression?

A screenshot actual vs expected is attached.

Thanks for checking.

Comment 1

[Mehmet]

Attachment: Bildschirmfoto 2021-05-02 um 10.13.20.png

Looks like the close button just only needs to be moved a few pixels to the right, so that it is nicely centered between the text and the chiclet border. That would fix that problem :)

Comment 2

[Mehmet]

If a recent regression, maybe caused by bug 1708533 ?

Comment 3

[Mehmet]

Definitely a recent regression and probably caused by bug 1708533. I was able to reproduce by updating a few days old Nightly to todays Nightly. The button was before nicely centered between text and border.

htwyford@: Can you please take a look at this issue? Many thanks in advance :)

Comment 4

[Marco Bonardo [:mak]]

This is actually correct according to the spec, we'll have to ask to update the spec if it's not good.

Comment 5

[Mehmet]

(In reply to Marco Bonardo [:mak] from comment #4)

This is actually correct according to the spec, we'll have to ask to update the spec if it's not good.

Okay, thank you :)

Comment 6

[Harry Twyford]

UX says we're good to move the close button 2px to the right.

Comment 7

[Harry Twyford]

Attachment: Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!

Comment 8

[Harry Twyford]

Comment on attachment 9219874 [details]
Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!

Beta/Release Uplift Approval Request

• User impact if declined: UX papercut in Proton.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tiny CSS change (increasing a margin by 2px).
• String changes made/needed:

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6518ee4ceeb4
Increase search mode chiclet title's margin-inline-end by 2px. r=mak

Comment 10

[Harry Twyford]

(In reply to Harry Twyford [:harry] from comment #8)

• Why is the change risky/not risky? (and alternatives if risky): Tiny CSS change (increasing a margin by 2px).

To elaborate on this, the change is scoped to a single element and is well-understood.

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6518ee4ceeb4

Comment 12

[Mehmet]

Attachment: Bildschirmfoto 2021-05-04 um 15.36.03.png

Thanks. Looks good now :)

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9219874 [details]
Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!

Low risk, approved for 89 beta 8, thanks.

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/04da195ef402

Comment 15

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8