Closed Bug 1708960 Opened 7 months ago Closed 7 months ago

[Proton] Close button's hover state of the chiclet is too close to the chiclet text

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
1

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: mehmet.sahin, Assigned: harry)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar] [proton-uplift])

Attachments

(3 files, 1 obsolete file)

Attached image actual_vs_expected.png (obsolete) —

Nightly 90.0a1 (2021-05-01) (64-Bit)
MacOS

1.) Take a look at the close button's hover state

Actual: It is too close to the text.

Expected: There could be a few pixels more padding between text and button to breathe :)

Not sure if this is a recent regression?

A screenshot actual vs expected is attached.

Thanks for checking.

Looks like the close button just only needs to be moved a few pixels to the right, so that it is nicely centered between the text and the chiclet border. That would fix that problem :)

Attachment #9219731 - Attachment is obsolete: true

If a recent regression, maybe caused by bug 1708533 ?

Definitely a recent regression and probably caused by bug 1708533. I was able to reproduce by updating a few days old Nightly to todays Nightly. The button was before nicely centered between text and border.

htwyford@: Can you please take a look at this issue? Many thanks in advance :)

Flags: needinfo?(htwyford)

This is actually correct according to the spec, we'll have to ask to update the spec if it's not good.

(In reply to Marco Bonardo [:mak] from comment #4)

This is actually correct according to the spec, we'll have to ask to update the spec if it's not good.

Okay, thank you :)

UX says we're good to move the close button 2px to the right.

Assignee: nobody → htwyford
Severity: -- → S4
Status: NEW → ASSIGNED
Iteration: --- → 90.2 - May 3 - May 16
Points: --- → 1
Flags: needinfo?(htwyford)
Priority: -- → P2
Whiteboard: [proton-address-bar]

Comment on attachment 9219874 [details]
Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!

Beta/Release Uplift Approval Request

  • User impact if declined: UX papercut in Proton.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Tiny CSS change (increasing a margin by 2px).
  • String changes made/needed:
Attachment #9219874 - Flags: approval-mozilla-beta?
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6518ee4ceeb4
Increase search mode chiclet title's margin-inline-end by 2px. r=mak

(In reply to Harry Twyford [:harry] from comment #8)

  • Why is the change risky/not risky? (and alternatives if risky): Tiny CSS change (increasing a margin by 2px).

To elaborate on this, the change is scoped to a single element and is well-understood.

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-address-bar] → [proton-address-bar] [proton-uplift]

Thanks. Looks good now :)

Comment on attachment 9219874 [details]
Bug 1708960 - Increase search mode chiclet title's margin-inline-end by 2px. r?Mak!

Low risk, approved for 89 beta 8, thanks.

Attachment #9219874 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.