1708985 - Choices in drop-down menu are invisible with Proton dark theme

Status: VERIFIED FIXED

(Firefox :: Foxfooding, defect, P1)

Description

[Liam England]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Actual user agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

1. Enable Proton dark theme
2. Visit https://milkbarstore.com/collections/mothers-day-shop and click on quick view on one of the products
3. Open the quantity drop-down menu

Actual results:

The choices in the drop-down menu are invisible except for the one under the cursor

Expected results:

The drop-down menu's choices should be visible

Comment 1

[Liam England]

Whoops, I meant to file this in Foxfooding. Can someone move it there?

Comment 2

[Liam England]

Never mind.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:liamrengland, could you try to find a regression range using for example mozregression?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1703716

Comment 5

[Romain Testard [:RT]]

This can be reproduced on Beta, marking as P1 since this is something we should fix on beta 89 as well.

Comment 6

[:Gijs (he/him)]

With the prefs for the win10 context menu enabled, this regressed with bug 1702626.

Comment 7

[:Gijs (he/him)]

I have a fix, just working on an automated test...

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1708985 - enforce the default background colour on the ContentSelect menulist's menupopup when custom option foreground colours are used, r?emilio!,jaws!

Broadly, this patch does 2 things:

• it mirrors the logic bug 1702258 introduced for <select> styling for <option> styling
• it enforces that if the website specifies custom foreground colours for options,
  we use the website-specified colour for the select background, too (even if it
  matches the UA style).

I also added automated testing for 3 cases:

1. the default dark mode situation (where we expect dark mode styles),
2. the case from the bug where the website specifies #fff for the background
   of the select and the background of the options, but specifies a custom
   foreground colour for the option (but not the select).
3. a very similar case where the website only specifies the background on the
   select, and only the foreground on the option.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75badaa5291a
enforce the default background colour on the ContentSelect menulist's menupopup when custom option foreground colours are used, r=emilio,jaws

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/75badaa5291a

Comment 11

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using Firefox 89 beta 8, verified that this is fixed using latest Nightly 90.0a1.

Comment 12

[:Gijs (he/him)]

Romain, I'm guessing you'd like me to request uplift here?

Comment 13

[Shilpa Mohanty]

Approved for Uplift.

Comment 14

[:Gijs (he/him)]

Comment on attachment 9220416 [details]
Bug 1708985 - enforce the default background colour on the ContentSelect menulist's menupopup when custom option foreground colours are used, r?emilio!,jaws!

Beta/Release Uplift Approval Request

• User impact if declined: Unusable dropdowns on websites if using dark mode
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: nope
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only affects the select dropdown colouring which is what's broken, and increases automated test coverage for the brokenness. Only 1 JS file is affected.
• String changes made/needed: Nope

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9220416 [details]
Bug 1708985 - enforce the default background colour on the ContentSelect menulist's menupopup when custom option foreground colours are used, r?emilio!,jaws!

Approved for 89 beta 11, thanks.

Comment 16

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/119d334dafa7

Comment 17

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 89.0b11 (provided in comment 16) on Windows 10 64bit. The drop-down menu choices for the products on https://milkbarstore.com/collections/mothers-day-shop are now visible