1708993 - Use menulist.value instead of menulist.selectedItem.getAttribute("value") in compose window

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, task)

Description

[Ian Neal]

This ports the relevant parts of:

• Bug 1290755 - use menulist.value instead of menulist.selectedItem.getAttribute("value") in TB compose window
• Bug 824150 - Code cleanup in /mail/ and /mailnews/: Use new String methods like startsWith, endsWith, contains, remaining Services.jsm switches and querySelector use instead of NodeList calls - compose
• Bug 1110166 - Port |Bug 1102219 - Rename String.prototype.contains to String.prototype.includes| to comm-central

Comment 1

[Ian Neal]

Attachment: 1708993-port1290755-2538.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9219751 [details] [diff] [review]
1708993-port1290755-2538.patch

LGTM

NIT as discussed:

• if (!msgCompFields) {
• throw new Error("Message Compose Error: msgCompFields is null (ExtractRecipients)");
• return;
• }

The return is imho dead code but can stay to match TB code.

Comment 3

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/2d45461852bcb40df454e4285f4f82b788a36d3b
Use menulist.value instead of menulist.selectedItem.getAttribute("value") in compose window. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/de3a6d34c1af6ba5df2f6ee388a2298424b22b31
Use menulist.value instead of menulist.selectedItem.getAttribute("value") in compose window. r=frg a=frg