1709261 - Help | troubleshooting yields Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://messenger/content/about-support/aboutSupport.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Attachment: Screen Shot 2021-05-03 at 10.15.44 PM.png

+++ This bug was initially created as a clone of Bug #1339436 +++

I just encountered this with 89.0b2 on Mac after a crash. Troubleshooting is missing the contents of the labels column

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://messenger/content/about-support/aboutSupport.js :: application :: line 259" data: no] aboutSupport.js:259:27
application chrome://messenger/content/about-support/aboutSupport.js:259
onload chrome://messenger/content/about-support/aboutSupport.js:57
<anonymous> self-hosted:1225

Comment 1

[Richard Marti (:Paenglab)]

This is no regression from 89. This happens on 78 too.

The error comes from here https://searchfox.org/comm-central/rev/6dbfd83437bab124d39332c768a5f55a36e7a196/mail/components/about-support/content/aboutSupport.js#259 because https://searchfox.org/comm-central/rev/6dbfd83437bab124d39332c768a5f55a36e7a196/mail/components/about-support/AboutSupportMac.jsm#14 returns null and there is no null check.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1709261-fsType-check.patch

Is the check like this okay? And is the try/catch still needed with this check?

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9220031 [details] [diff] [review]
1709261-fsType-check.patch

Review of attachment 9220031 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like the try/catch should still be kept

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b9ca56755852
in about:support, check fsType validity before get a string name. r=mkmelin

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9220031 [details] [diff] [review]
1709261-fsType-check.patch

[Approval Request Comment]
User impact if declined: on Mac error message when opening the troubleshooting information
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9220031 [details] [diff] [review]
1709261-fsType-check.patch

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 89.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/5e7206df47ed

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9220031 [details] [diff] [review]
1709261-fsType-check.patch

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.10.2:
https://hg.mozilla.org/releases/comm-esr78/rev/e331955627fc