1709346 - Pages never finish loading if twitter timeline embedded on site

Robin Edwards

Reporter

Description

•

3 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

It seems that any website with an embedded twitter timeline will never properly finish loading.

The third icon on the toolbar remains a cross (stop loading) rather than refresh, and the bottom right of the screen shows "Read platform.twitter.com" (or similar).

To reproduce:
Visiting the twitter develop page for embedded timelines, or by making a simple page that simply embeds an example timeline.

https://developer.twitter.com/en/docs/twitter-for-websites/timelines/overview

This seems to be a new bug in firefox 88. It does not happen in firefox 87 or earlier.
(note that uBlock origin prevents this bug from being seen - needs to be disabled.)

Actual results:

The page will never properly finish loading in firefox 88.
The third icon on the toolbar remains a cross (stop loading) rather than refresh, and the bottom right of the screen shows "Read platform.twitter.com" (or similar).

Expected results:

The page loads normally, and the refresh icon is seen on the toolbar. No outstanding requests show at the bottom right of the screen. (Behaviour prior to firefox 88).

Alice0775 White

Comment 1

•

3 years ago

I can reproduce the issue on Nightly90.0a1 windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1f6ce1f03e8421433a6942dc2e132d194a87ce9f&tochange=8657e72a09f7d33560fe93a45a5520e07e129a1b

Regressed by Bug 1209947 and Bug 1663757

Status: UNCONFIRMED → NEW

Has Regression Range: --- → yes

Has STR: --- → yes

status-firefox88: --- → affected

status-firefox89: --- → affected

status-firefox90: --- → affected

status-firefox-esr78: --- → unaffected

Component: Untriaged → DOM: Navigation

Ever confirmed: true

Keywords: regression

Product: Firefox → Core

Regressed by: 1663757, 1209947

Henrik Skupin [:whimboo][⌚️UTC+2]

Comment 2

•

3 years ago

Nika, could you please have a look?

Flags: needinfo?(nika)

Ryan VanderMeulen [:RyanVM]

Updated

•

3 years ago

status-firefox88: affected → wontfix

Chris Peterson [:cpeterson]

Comment 3

•

3 years ago

Nika, this looks like a high-priority regression in 89 Beta.

Assignee: nobody → nika

Severity: -- → S2

Priority: -- → P1

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 4

•

3 years ago

I looked into this some more today, and it seems like this is a symptom of the generalized issue whcih https://bugzilla.mozilla.org/show_bug.cgi?id=1704651 tried to fix for toplevel documents. To fix this we'll probably need to create synthetic STATE_STOP notifications for subframes when their BC is discarded.

Pascal Chevrel:pascalc

Updated

•

3 years ago

status-firefox89: affected → wontfix

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 5

•

3 years ago

Attached file Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, — Details

This allows loads to be tracked as they are ongoing on a per-context basis in
the parent process, and for events to be generated for each subframe as it is
destroyed.

This patch also stops sending the IsLoadingDocument flag on the request to
the main process and removes RemoteWebProgress, as they are no longer necessary
due to being tracked directly.

Finally this patch also adds some logging to BrowsingContextWebProgress
to make it easier to diagnose this type of issue in the future.

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 6

•

3 years ago

Attached file Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, — Details

This seems to be the behaviour which was causing the failures with twitter embeds.

Pulsebot

Comment 7

•

3 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/602a7b4a41de Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/19df1a8bfacc Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag

Atila Butkovits

Comment 8

•

3 years ago

•

Edited

Backed out for causing failures on browser_bug1709346.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc37b4eedd7d631bb0c54941843f3988137eace4

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc26&revision=19df1a8bfacc64af8cd90926550cd820e1709957&selectedTaskRun=HDYuvHFoRPuPmgLfXPhT0Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=340751477&repo=autoland&lineNumber=2417

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

3 years ago

Flags: needinfo?(nika)

Pulsebot

Comment 9

•

3 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34eff3430674 Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/7c1e15680741 Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag

Natalia Csoregi [:nataliaCs]

Comment 10

•

3 years ago

Backed out for causing XPCConvert crashes

backout: https://hg.mozilla.org/integration/autoland/rev/ff728b554633c9f40904af85ad8474b8cf7e7588

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=KRnpZbZtRBKBMTQhYplRig.0&revision=7c1e15680741ff8e18835b771c27bc7a7f0c0c53

failure log: https://treeherder.mozilla.org/logviewer?job_id=340778486&repo=autoland&lineNumber=22979

multiple other failures appeared on a push from later on: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=2eea3e40c7ed9bda2829b4818c3eb79e3ef5fbf4&selectedTaskRun=LY-9ghyfR0ulkgs-5I6KQQ.0

[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - PROCESS-CRASH | /service-workers/service-worker/update-on-navigation.https.html | application crashed [@ XPCConvert::NativeData2JS(JSContext*, JS::MutableHandle<JS::Value>, void const*, nsXPTType const&, nsID const*, unsigned int, nsresult*)]
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - Crash dump filename: /var/folders/fn/jpjnpp817tg6r6w_7zq4f_0c000014/T/tmp4xqzif5_/minidumps/C18C9306-547A-4B85-A133-6B1CD3E22A5A.dmp
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - Operating system: Mac OS X
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO -                   10.15.7 19H524
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - CPU: amd64
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO -      family 6 model 158 stepping 10
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO -      12 CPUs
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - 
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - GPU: UNKNOWN
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - 
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - Crash reason:  EXC_BAD_ACCESS / EXC_I386_GPFLT
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - Crash address: 0x0
[task 2021-05-25T21:26:22.006Z] 21:26:22     INFO - Process uptime: 245 seconds
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO - 
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO - Thread 0 (crashed)
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -  0  XUL!XPCConvert::NativeData2JS(JSContext*, JS::MutableHandle<JS::Value>, void const*, nsXPTType const&, nsID const*, unsigned int, nsresult*) [XPCConvert.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 354 + 0x1b]
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rax = 0xe5e5e5e5e5e5e5e5   rdx = 0x00007ffee9bb6478
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rcx = 0x000000011744c598   rbx = 0x0000000000000000
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rsi = 0x000000011826e400   rdi = 0x00000001223da400
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb64e0   rsp = 0x00007ffee9bb6460
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -      r8 = 0x00007ffee9bb6870    r9 = 0x0000000000000000
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     r10 = 0x000000010c780010   r11 = 0x000000010ef25cf0
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     r12 = 0x00007ffee9bb6968   r13 = 0x00007ffee9bb6968
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     r14 = 0x000000010c535000   r15 = 0x00007ffee9bb6870
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rip = 0x000000010fd0f586
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     Found by: given as instruction pointer in context
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -  1  XUL!nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) [XPCWrappedJSClass.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 923 + 0x2c]
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6920   rsp = 0x00007ffee9bb64f0
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rip = 0x000000010fd50a3d
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -  2  XUL!PrepareAndDispatch [xptcstubs_x86_64_darwin.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 117 + 0x29]
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6a00   rsp = 0x00007ffee9bb6930
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rip = 0x000000010f010cb5
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -  3  XUL!SharedStub + 0x5b
[task 2021-05-25T21:26:22.007Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6a80   rsp = 0x00007ffee9bb6a10
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rip = 0x000000010f00fa1b
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -  4  XUL!nsBrowserStatusFilter::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) [nsBrowserStatusFilter.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 157 + 0x17]
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6ad0   rsp = 0x00007ffee9bb6a90
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rip = 0x0000000114950456
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -  5  XUL!mozilla::dom::BrowsingContextWebProgress::UpdateAndNotifyListeners(unsigned int, std::__1::function<void (nsIWebProgressListener*)> const&) [BrowsingContextWebProgress.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 118 + 0x17]
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6b70   rsp = 0x00007ffee9bb6ae0
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rip = 0x00000001144b175d
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -  6  XUL!mozilla::dom::BrowsingContextWebProgress::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) [BrowsingContextWebProgress.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 222 + 0xb]
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6c60   rsp = 0x00007ffee9bb6b80
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rip = 0x00000001144b1ebe
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -  7  XUL!{virtual override thunk({offset(-8)}, mozilla::dom::BrowsingContextWebProgress::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult))} + 0xd
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6c70   rsp = 0x00007ffee9bb6c70
[task 2021-05-25T21:26:22.008Z] 21:26:22     INFO -     rip = 0x00000001144b27dd
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -  8  XUL!mozilla::dom::BrowsingContextWebProgress::UpdateAndNotifyListeners(unsigned int, std::__1::function<void (nsIWebProgressListener*)> const&) [BrowsingContextWebProgress.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 127 + 0x26]
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6d10   rsp = 0x00007ffee9bb6c80
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     rip = 0x00000001144b1891
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -  9  XUL!mozilla::dom::BrowsingContextWebProgress::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) [BrowsingContextWebProgress.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 222 + 0xb]
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6e00   rsp = 0x00007ffee9bb6d20
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     rip = 0x00000001144b1ebe
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO - 10  XUL!mozilla::dom::CanonicalBrowsingContext::CanonicalDiscard() [CanonicalBrowsingContext.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 1065 + 0x42]
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6e50   rsp = 0x00007ffee9bb6e10
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     rip = 0x000000011449dda3
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.009Z] 21:26:22     INFO - 11  XUL!mozilla::dom::BrowsingContext::Detach(bool) [BrowsingContext.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 892 + 0x15]
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6f70   rsp = 0x00007ffee9bb6e60
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rip = 0x000000011449d61e
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO - 12  XUL!mozilla::dom::ContentParent::RecvDiscardBrowsingContext(mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> const&, std::__1::function<void (bool const&)>&&) [ContentParent.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 6687 + 0xd]
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb6fb0   rsp = 0x00007ffee9bb6f80
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rip = 0x0000000112b6d0e8
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO - 13  XUL!mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&) [PContentParent.cpp: : 13654 + 0xb]
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb80d0   rsp = 0x00007ffee9bb6fc0
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rip = 0x000000010f90b848
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO - 14  XUL!mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [MessageChannel.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 2155 + 0xe]
[task 2021-05-25T21:26:22.010Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8140   rsp = 0x00007ffee9bb80e0
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rip = 0x000000010f7e849f
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO - 15  XUL!mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [MessageChannel.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 2079 + 0xe]
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8230   rsp = 0x00007ffee9bb8150
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rip = 0x000000010f7e5ea8
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO - 16  XUL!mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [MessageChannel.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 1924 + 0xb]
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb82a0   rsp = 0x00007ffee9bb8240
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rip = 0x000000010f7e6c06
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO - 17  XUL!mozilla::ipc::MessageChannel::MessageTask::Run() [MessageChannel.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 1955 + 0xc]
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb82c0   rsp = 0x00007ffee9bb82b0
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rip = 0x000000010f7e73c9
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO - 18  XUL!mozilla::RunnableTask::Run() [TaskController.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 482 + 0x13]
[task 2021-05-25T21:26:22.011Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8740   rsp = 0x00007ffee9bb82d0
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rip = 0x000000010efea8bb
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO - 19  XUL!mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [TaskController.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 766 + 0x9]
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8960   rsp = 0x00007ffee9bb8750
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rip = 0x000000010efc7c48
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO - 20  XUL!mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [TaskController.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 621 + 0x5]
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb89a0   rsp = 0x00007ffee9bb8970
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rip = 0x000000010efc69f6
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO - 21  XUL!mozilla::TaskController::ProcessPendingMTTask(bool) [TaskController.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 405 + 0x8]
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb89f0   rsp = 0x00007ffee9bb89b0
[task 2021-05-25T21:26:22.012Z] 21:26:22     INFO -     rip = 0x000000010efc6b8e
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO - 22  XUL!mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() [nsThreadUtils.h:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 534 + 0x13]
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8a00   rsp = 0x00007ffee9bb8a00
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     rip = 0x000000010eff0257
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO - 23  XUL!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 1159 + 0x16]
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8b20   rsp = 0x00007ffee9bb8a10
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     rip = 0x000000010efd9252
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO - 24  XUL!NS_ProcessPendingEvents(nsIThread*, unsigned int) [nsThreadUtils.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 496 + 0xf]
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8b70   rsp = 0x00007ffee9bb8b30
[task 2021-05-25T21:26:22.013Z] 21:26:22     INFO -     rip = 0x000000010efd64f8
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO - 25  XUL!nsBaseAppShell::NativeEventCallback() [nsBaseAppShell.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 87 + 0x14]
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8ba0   rsp = 0x00007ffee9bb8b80
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rip = 0x0000000113027d62
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO - 26  XUL!nsAppShell::ProcessGeckoEvents(void*) [nsAppShell.mm:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 467 + 0x8]
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8bf0   rsp = 0x00007ffee9bb8bb0
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rip = 0x00000001130b2a36
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO - 27  CoreFoundation!__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 0x11
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8c00   rsp = 0x00007ffee9bb8c00
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rip = 0x00007fff359bdd52
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO - 28  CoreFoundation!__CFRunLoopDoSource0 + 0x67
[task 2021-05-25T21:26:22.014Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8c30   rsp = 0x00007ffee9bb8c10
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rip = 0x00007fff359bdcf1
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO - 29  CoreFoundation!__CFRunLoopDoSources0 + 0xd1
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb8ca0   rsp = 0x00007ffee9bb8c40
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rip = 0x00007fff359bdb0b
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO - 30  CoreFoundation!__CFRunLoopRun + 0x39f
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb99b0   rsp = 0x00007ffee9bb8cb0
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rip = 0x00007fff359bc83a
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO - 31  CoreFoundation!CFRunLoopRunSpecific + 0x1ce
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb9a40   rsp = 0x00007ffee9bb99c0
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rip = 0x00007fff359bbe3e
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO - 32  HIToolbox!RunCurrentEventLoopInMode + 0x124
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb9a90   rsp = 0x00007ffee9bb9a50
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     rip = 0x00007fff345e8abd
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.015Z] 21:26:22     INFO - 33  HIToolbox!ReceiveNextEventCommon + 0x248
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb9b10   rsp = 0x00007ffee9bb9aa0
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rip = 0x00007fff345e87d5
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO - 34  HIToolbox!_BlockUntilNextEventMatchingListInModeWithFilter + 0x40
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb9b30   rsp = 0x00007ffee9bb9b20
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rip = 0x00007fff345e8579
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO - 35  AppKit!_DPSNextEvent + 0x373
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rbp = 0x00007ffee9bb9f30   rsp = 0x00007ffee9bb9b40
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rip = 0x00007fff32c2e039
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO - 36  AppKit!-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 0x548
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba190   rsp = 0x00007ffee9bb9f40
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rip = 0x00007fff32c2c880
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO - 37  XUL!-[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [nsAppShell.mm:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 170 + 0x29]
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba1f0   rsp = 0x00007ffee9bba1a0
[task 2021-05-25T21:26:22.016Z] 21:26:22     INFO -     rip = 0x00000001130b1e4e
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO - 38  AppKit!-[NSApplication run] + 0x292
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba2b0   rsp = 0x00007ffee9bba200
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rip = 0x00007fff32c1e58e
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO - 39  XUL!nsAppShell::Run() [nsAppShell.mm:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 732 + 0x1a]
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba300   rsp = 0x00007ffee9bba2c0
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rip = 0x00000001130b31f8
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO - 40  XUL!nsAppStartup::Run() [nsAppStartup.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 273 + 0xf]
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba330   rsp = 0x00007ffee9bba310
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rip = 0x000000011494bb40
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO - 41  XUL!XREMain::XRE_mainRun() [nsAppRunner.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 5244 + 0x16]
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba4d0   rsp = 0x00007ffee9bba340
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     rip = 0x0000000114a81299
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.017Z] 21:26:22     INFO - 42  XUL!XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 5442 + 0x8]
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba560   rsp = 0x00007ffee9bba4e0
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rip = 0x0000000114a82948
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO - 43  XUL!XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 5501 + 0x10]
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rbp = 0x00007ffee9bba6a0   rsp = 0x00007ffee9bba570
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rip = 0x0000000114a83285
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO - 44  firefox!main [nsBrowserApp.cpp:7c1e15680741ff8e18835b771c27bc7a7f0c0c53 : 351 + 0x2cb]
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rbp = 0x00007ffee9bbab10   rsp = 0x00007ffee9bba6b0
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rip = 0x0000000106045367
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO - 45  libdyld.dylib!start + 0x1
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rbp = 0x00007ffee9bbab28   rsp = 0x00007ffee9bbab20
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rip = 0x00007fff6f8c4cc9
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     Found by: previous frame's frame pointer
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO - 46  libdyld.dylib!start + 0x1
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rbp = 0x00007ffee9bbab28   rsp = 0x00007ffee9bbab28
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     rip = 0x00007fff6f8c4cc9
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -     Found by: stack scanning
[task 2021-05-25T21:26:22.018Z] 21:26:22     INFO -

Flags: needinfo?(nika)

Pulsebot

Comment 11

•

3 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/866026daf2b2 Part 1: Track BrowsingContextWebProgress for subframes, r=mattwoodrow,kmag,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/8addd27bba14 Part 2: Add test for cancelling a long-running load by removing its subframes, r=kmag

Atila Butkovits

Comment 12

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/866026daf2b2
https://hg.mozilla.org/mozilla-central/rev/8addd27bba14

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox91: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 91 Branch

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

3 years ago

Flags: needinfo?(nika)

BugBot [:suhaib / :marco/ :calixte]

Comment 13

•

3 years ago

The patch landed in nightly and beta is affected.
:nika, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nika)

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 14

•

3 years ago

Comment on attachment 9222989 [details]
Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes,

Beta/Release Uplift Approval Request

User impact if declined: Pages appear to never finish loading in some situations (such as those including a twitter timeline)
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce: Could be manually verified using the steps in comment 0 after uplift, however Part 2 contains an automated test.
List of other uplifts needed: None
Risk to taking this patch: Medium
Why is the change risky/not risky? (and alternatives if risky): This is a fairly substantial patch which has only been on nightly for a few days, changing a fairly central part of how we track loads in particular frames.
String changes made/needed: None

Flags: needinfo?(nika)

Attachment #9222989 - Flags: approval-mozilla-beta?

Nika Layzell [:nika] (ni? for response)

Assignee

Updated

•

3 years ago

Attachment #9222990 - Flags: approval-mozilla-beta?

Julien Cristau [:jcristau]

Comment 15

•

3 years ago

Comment on attachment 9222989 [details]
Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes,

we've got some time left in beta this cycle, so let's try this.
approved for 90.0b5

Attachment #9222989 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Julien Cristau [:jcristau]

Updated

•

3 years ago

Attachment #9222990 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Julien Cristau [:jcristau]

Comment 16

•

3 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/972632674e10
https://hg.mozilla.org/releases/mozilla-beta/rev/f37e95f3262e

status-firefox90: affected → fixed

Flags: in-testsuite+

Cristian Baica [:cbaica], Release Desktop QA

Updated

•

3 years ago

Flags: qe-verify+

Brindusa Tot, Desktop QA

Updated

•

3 years ago

QA Whiteboard: [qa-triaged]

Raluca Popovici, Desktop QA

Comment 17

•

3 years ago

I can confirm the issue from comment 0 on Fx 88.
Verified fixed on Fx 90.0b5 and Nightly 91.0a1(2021-06-07) using MacOS 10.15.6 and MacOS 11.

Status: RESOLVED → VERIFIED

QA Whiteboard: [qa-triaged]

status-firefox90: fixed → verified

status-firefox91: fixed → verified

Flags: qe-verify+

Bug 1709346 - Part 1: Track BrowsingContextWebProgress for subframes, 3 years ago Nika Layzell [:nika] (ni? for response) 48 bytes, text/x-phabricator-request	jcristau : approval-mozilla-beta+	Details \| Review
Bug 1709346 - Part 2: Add test for cancelling a long-running load by removing its subframes, 3 years ago Nika Layzell [:nika] (ni? for response) 48 bytes, text/x-phabricator-request	jcristau : approval-mozilla-beta+	Details \| Review