1709350 - Remove the rest of panelUI-custom-colors.inc.css

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Dão Gottwald [:dao]]

• --panelview-toolbarbutton-hover-bgcolor and --panelview-toolbarbutton-active-bgcolor are the same as --button-hover-bgcolor and --button-active-bgcolor
• --panel-separator-zap-gradient was already set to the same value
• --panelview-toolbarbutton-focus-box-shadow should re-use --focus-outline-color
• --panel-disabled-color overrides toolkit and can just move to browser-custom-colors.inc.css, --panel-shortcut-color can move along with it

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1709350 - Remove the rest of panelUI-custom-colors.inc.css. r=mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd2220868f4e
Remove the rest of panelUI-custom-colors.inc.css. r=mconley

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cd2220868f4e

Comment 4

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Hey dao, would you feel comfortable requesting uplift for this bug to beta? We realized that it fixes bug 1704817.

Comment 5

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Alternatively, I can request uplift for you - just say the word. I just wanted to make sure you were in the loop.

Comment 6

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Okay, going to tentatively request uplift on this one so that bug 1704817 can get closed.

Comment 7

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Comment on attachment 9220116 [details]
Bug 1709350 - Remove the rest of panelUI-custom-colors.inc.css. r=mconley

Beta/Release Uplift Approval Request

• User impact if declined: Users that rely on focus rings inside of the AppMenu (and some subpanels) will find that the focus ring doesn't match the theme that they're using, and is actually using the OS accent colour.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is clean-up work that happens to also fix the underlying issue. The clean-up work is pretty trivial, and has been baking on Nightly for a number of days.
• String changes made/needed: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9220116 [details]
Bug 1709350 - Remove the rest of panelUI-custom-colors.inc.css. r=mconley

Approved for 89.0b12.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e5565287632f