Closed Bug 1709350 Opened 3 months ago Closed 3 months ago

Remove the rest of panelUI-custom-colors.inc.css

Categories

(Firefox :: Theme, task, P3)

task
Points:
2

Tracking

()

RESOLVED FIXED
90 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanup] [proton-uplift])

Attachments

(1 file)

  • --panelview-toolbarbutton-hover-bgcolor and --panelview-toolbarbutton-active-bgcolor are the same as --button-hover-bgcolor and --button-active-bgcolor
  • --panel-separator-zap-gradient was already set to the same value
  • --panelview-toolbarbutton-focus-box-shadow should re-use --focus-outline-color
  • --panel-disabled-color overrides toolkit and can just move to browser-custom-colors.inc.css, --panel-shortcut-color can move along with it
Whiteboard: [proton-cleanup]
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd2220868f4e
Remove the rest of panelUI-custom-colors.inc.css. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Priority: -- → P3

Hey dao, would you feel comfortable requesting uplift for this bug to beta? We realized that it fixes bug 1704817.

Flags: needinfo?(dao+bmo)

Alternatively, I can request uplift for you - just say the word. I just wanted to make sure you were in the loop.

Okay, going to tentatively request uplift on this one so that bug 1704817 can get closed.

Comment on attachment 9220116 [details]
Bug 1709350 - Remove the rest of panelUI-custom-colors.inc.css. r=mconley

Beta/Release Uplift Approval Request

  • User impact if declined: Users that rely on focus rings inside of the AppMenu (and some subpanels) will find that the focus ring doesn't match the theme that they're using, and is actually using the OS accent colour.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is clean-up work that happens to also fix the underlying issue. The clean-up work is pretty trivial, and has been baking on Nightly for a number of days.
  • String changes made/needed: None.
Attachment #9220116 - Flags: approval-mozilla-beta?
Flags: needinfo?(dao+bmo)

Comment on attachment 9220116 [details]
Bug 1709350 - Remove the rest of panelUI-custom-colors.inc.css. r=mconley

Approved for 89.0b12.

Attachment #9220116 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [proton-cleanup] → [proton-cleanup] [proton-uplift]
You need to log in before you can comment on or make changes to this bug.