1709535 - window control buttons (minimize, maximize, close) replaced with black rectangle, at least on Windows 8.1

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 90.0a1 20210504214950 on Windows 8.1 (works as expected with Windows 10)

The window control buttons (minimize, maximize, close) are not visible but a black rectangle is shown. Bisection identified bug 1696905 as regressor.

This will be resolved in the next Nightly.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot: window control buttons black

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1709535 - Fix clear tiles. r=#gfx-reviewers

In bug 1696905 I changed how clear tiles are rendered from multiply blend to opaque, however it breaks window controls on Windows 8 (the only thing that clear tiles are used for). This patch reverts clear tiles to the previous behavior.

I'm not sure how to test this part of the code because it depends on the widget integration code having something to show behind the window.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdcb5a739952
Fix clear tiles. r=gfx-reviewers,jnicol

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9519a9236337
Fix clear tiles. r=gfx-reviewers,jnicol

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9519a9236337

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fdcb5a739952

Comment 8

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Fx 90.0a1 (2021.05.04) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using 90.0b4 on Win 8.1 x64.