1709619 - Handle private fields in getSymbols

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

getSymbols is used by the debugger to retrieve information on a given script that are then used in features (e.g. variable tooltip, function list, ...)

It doesn't handle private fields at all and this breaks some features

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1709619 - [devtools] Handle private fields when retrieving script Symbols. r=bomsy.

Symbols are information on the structure of a given script (assignments, functions,
expressions, …)

This patch handles scripts using private fields and fixes a few things in the debugger:

• we get the full expression when hovering a private property access,
  a prerequisite to get the value of a private propery in the variable tooltip
  (which will be handled in Bug 1709567).
• private methods now show up in the outline view under their proper name, and
  not anonymous. simplifyDisplayName was fixed as well to not strip the #
  at the start of the method name.

Tests are added to ensure this works as expected.

Depends on D114345

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4042e167b1bd
[devtools] Handle private fields when retrieving script Symbols. r=bomsy.

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4042e167b1bd