Closed Bug 1710417 Opened 3 years ago Closed 3 years ago

pretty printing expression with private fields strips out # characters

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

With Bug 1709619, we fixed (partially) pretty printing a file containing private fields.
The issue is that the library we use (pretty-fast), does remove all # characters, and the formatted script doesn't reflect the actual content of the original script anymore.

The library fix will happen in https://github.com/mozilla/pretty-fast/issues/48 , and this bug should be about updating the library

This fixes an issue we had with pretty printing scripts
containing private fields.
A test case is added in browser_dbg-pretty-print.js to
ensure it stays this way.

Attachment #9221271 - Attachment description: Bug 1710417 - [devtools] Update pretty-fast to 0.2.6. r=bomsy. → Bug 1710417 - [devtools] Update pretty-fast to 0.2.6. r=ladybenko.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70e6410f7197
[devtools] Update pretty-fast to 0.2.6. r=ladybenko.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: