"Take a Screenshot" button in toolbar is disabled on old Firefox window when new window is created by detaching a tab from old window
Categories
(Firefox :: Toolbars and Customization, defect, P5)
Tracking
()
People
(Reporter: mforsetti, Unassigned)
Details
Attachments
(5 files)
1.jpg
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0
Steps to reproduce:
- Start a Firefox instance.
- With "Customize Firefox", Put "Take a Screenshot" button to current Firefox instance toolbar.
- Browse to a new site. After the website is loaded, "Take a Screenshot" button will be enabled.
- Create a new tab. Here, the "Take a Screenshot" button will be disabled.
- Detach/tear newly created tab to create a new Firefox window.
- Observe "Take a Screenshot" button in old Firefox window.
Actual results:
"Take a Screenshot" button is disabled in old Firefox window.
Expected results:
"Take a Screenshot" button should be enabled in old Firefox window.
Trying to browse a new site in old Firefox window apparently re-enables "Take a Screenshot" button in new Firefox window, but only if new Firefox window have an empty tab active ("New Tab").
|
||
Comment 2•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Toolbars and Customization' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Comment 3•4 years ago
|
||
I'm having trouble reproducing this. In step 4, the "Take a screenshot" button is still enabled. Nonetheless, trying to click on the button when it is enabled will show a notification that says the current page doesn't support screenshots, so the severity here is pretty low.
I've added a short video for how to reproduce. Please note that even though it's running under PortableApps, it should also be reproducible in original Firefox 88 in Windows 10.
- 00.01 - 00.03 Start a Firefox instance.
- 00.03 - 00.11 With "Customize Firefox", Put "Take a Screenshot" button to current Firefox instance toolbar.
- 00.11 - 00.15 Browse to a new site. After the website is loaded, "Take a Screenshot" button will be enabled.
- 00.15 - 00.18 Create a new tab. Observe that new tab had "Take a Screenshot" button disabled.
- 00.18 - 00.21 Detach/tear newly created tab to create a new Firefox window. Observe that both old window (with a webpage loaded) and new window had "Take a Screenshot" button disabled. Should this old window with a webpage loaded had its "Take a Screenshot" button disabled?
- 00.21 - 00.23 New window had "Take a Screenshot" button enabled after loading a page. Old window still had its "Take a Screenshot" button disabled.
This other video demonstrates on how new window's "Take a Screenshot" button apparently still refers to old window rather than its new window
- 00.01 Continuing from previous reproduction, with new window having empty tab ("New Tab"). Observe that both window had "Take a Screenshot" button disabled.
- 00.09 Refreshing old window (or navigating to another webpage) will re-enable "Take a Screenshot" button on new window rather than old window.
- 00.10 Clicking on "Take a Screenshot" on new window (still with empty "New Tab") will emit an "We can't screenshot this page" error.
Apparently new window's "Take a Screenshot" state still refers to the old window, but the action is correct, i.e. screenshotting the new window instead of old one.
|
||
Comment 6•4 years ago
•
|
||
Hi mforsetti,
this could not be reproduced since 'Take a screenshot' button design has changed. In latest versions, Nightly 90.0a1 (2021-05-13) (64-bit) and Release 88.0.1 versions, after disabling the button, a message will appear in the right side bottom, reading 'We can't screenshot this page...', it won't be grayed out again. Thank you for taking the time to submit this bug report, and please, feel free to reopen it if you have any troubles.
Regards,
Jerónimo.
Hi Jerónimo Torti,
Actually, after reproduction steps completed, there are two problems here:
- is what you're explaining, that in the new window, we can click on "Take a Screenshot" button even though it's an empty tab (New Tab). This, I agree, can be resolved by showing an error and re-disabling the "Take a Screenshot" button; but
- "Take a Screenshot" button in the old Firefox window is permanently disabled for the whole session, until we close the window, since its state are taken by the new Firefox window. Try checking the "Take a Screenshot" button on the old Firefox window (see my demo videos), it should be disabled. It will stay disabled until you close the old window.
Problem #2 -- inability to take a screenshot -- is what I think need to be fixed, rather than Problem #1.
|
Reporter | |
Comment 10•4 years ago
|
||
Reproducible in Nightly 90.0a1
Hi mforsetti,
thank you for the effort and the videos, they cleared up the issue. Sorry for not confirming it after the first try, I don't know why the pop-up message appeared every time I tried to reproduce.
I was able to reproduce in Nightly 90.0a1 (2021-05-13) (64-bit) and Release 88.0.1 versions, the same way as shown in last video.
I marked this as New, and updated the flags accordingly.
Regards,
Jerónimo.
|
|
Reporter | |
Comment 12•4 years ago
|
||
Hi Jerónimo Torti,
No worries. My English is kinda bad, so I think it is probably me who’s failed to explain the problems clearly.
My work requires me to take web page screenshots -- often multiple times daily -- and this bug really breaks my workflow, so thanks for confirming this.
Cheers.
|
||
Comment 13•8 months ago
|
||
Reporter, are you still experiencing this issue?
|
|
||
Comment 14•8 months ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:Gijs, since the bug has recent activity, could you have a look please?
For more information, please visit BugBot documentation.
|
||
Comment 15•8 months ago
|
||
I expect this was fixed by moving screenshots to a builtin component such that it is now enabled on more pages (bug 1870127). If not, we probably want a new bug anyway.
Description
•