1710092 - Back out workaround from bug 1708809 once gNavToolbox and ancestors use CSS box model

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1708809, I hit an issue where the mixture of XUL box elements and CSS box elements were causing strange glitches when doing animations with negative margins.

Mixing those two box models is asking for trouble. We might be at the point where it's safe to convert the gNavToolbox, its contents and maybe its ancestors, to the CSS box model.

If this gets fixed, then the workaround landed in bug 1708809 can probably get removed.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Bug 1790616 should take care of this.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Cool - in that case, let's re-use this bug to backout the workaround landed for bug 1708809.

Comment 3

[Bernard Igiri]

Attachment: Bug 1710092 - Back out workaround from bug 1708809 r=mconley!

Backed out workaround from bug 1708809.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

needinfo to emilio for https://phabricator.services.mozilla.com/D159331#5230088.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I can't repro on latest central. Are you sure that you were testing with the second patch from bug 1790616? That didn't make it to central till this morning.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Bernard, would you be ok holding off landing this until after the soft freeze? Just in case we need to back out https://hg.mozilla.org/mozilla-central/rev/fb32775d2def from beta for regressions etc.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8140f297aa36
Back out workaround from bug 1708809 r=mconley

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out as req by Bernard
Backout link: https://hg.mozilla.org/integration/autoland/rev/0eef9419671dfd699c9b3aa700a27957af8031eb

Comment 9

[Bernard Igiri]

Is this clear to land as is?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

I don't think so - it relies on bug 1790616 landing and sticking, and that one got backed out. So we should hold off on this until that one re-lands.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48e103f63710
Back out workaround from bug 1708809 r=mconley

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/48e103f63710