1790616 - Use modern flexbox in the browser toolbox.

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1790616 - Use modern flexbox for the toolbox. r=dao,mak,Gijs

The min-width / contain are as usual to allow elements to shrink under
their intrinsic size. You can only see its effects with relatively thin
windows (or with a very large number of tabs in the tabstrip case).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1790616 - Use modern flexbox for the toolbox. r=dao,mak,Gijs

The min-width / contain are as usual to allow elements to shrink under
their intrinsic size. You can only see its effects with relatively thin
windows (or with a very large number of tabs in the tabstrip case).

Making it work in the browser area is blocked on making splitters work
on non-XUL boxes (so that DevTools can be resized), or replacing those
splitters with something else. I'll look at that next.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1790616 - Minor CSS tweaks that are needed for modern flexbox. r=dao

These fix rendering or test issues with flex emulation, but don't change
rendering without, so can land separately.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d7d8d037b0d
Minor CSS tweaks that are needed for modern flexbox. r=dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb32775d2def
Use modern flexbox for the toolbox. r=dao,Gijs

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7d7d8d037b0d

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fb32775d2def

Comment 9

[Norisz Fay [:noriszfay]]

Backed out changeset fb32775d2def as requested by dev. Backout link: https://hg.mozilla.org/integration/autoland/rev/4a24cecdad7190433bc76f853a9519c1e1e63447

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/984b9b9d0404
Backed out changeset fb32775d2def as requested by dev a=graft

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa325161aae5
Use modern flexbox for the toolbox. r=dao,Gijs

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/aa325161aae5

Comment 13

[Jim Jeffery not reading bug-mail 1/2/11]

Just updated to today's build after the landing of this path, the issue of huge drop lists is back, so the problem is not fixed.
crash report: Firefox 108.0a1 Crash Report [@ webrender::render_api::window_size_sanity_check ]

Build ID 20221018094831
change set; https://hg.mozilla.org/mozilla-central/rev/826073b561e026d8fbc6a8354081db59727d9f33

bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1705002

Comment 14

[:Gijs (he/him)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)

Just updated to today's build after the landing of this path, the issue of huge drop lists is back, so the problem is not fixed.
crash report: Firefox 108.0a1 Crash Report [@ webrender::render_api::window_size_sanity_check ]

Build ID 20221018094831
change set; https://hg.mozilla.org/mozilla-central/rev/826073b561e026d8fbc6a8354081db59727d9f33

A little more context in bug 1705002 - Jim, can you link to your crash report on crash-stats please?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)

Just updated to today's build after the landing of this path, the issue of huge drop lists is back, so the problem is not fixed.
crash report: Firefox 108.0a1 Crash Report [@ webrender::render_api::window_size_sanity_check ]

Which menu and on which OS?

Comment 16

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #15)

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)

Just updated to today's build after the landing of this path, the issue of huge drop lists is back, so the problem is not fixed.
crash report: Firefox 108.0a1 Crash Report [@ webrender::render_api::window_size_sanity_check ]

Which menu and on which OS?

The list-box is on a site that requires a login and being a member to the ARRL (Amateur Radio Relay League)
There is an option to 'find call' that you can check if they use the logbook on the ARRL site. That list-box usually lists the last 6 lookups.
The list is now over a full page tall and after 2-3 seconds crashes the entire browser.

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Oh, so a <select> menulist? That's useful, can try to repro. Also, what about the OS? Is this on Linux, macOS or Windows? Thanks again.

Comment 18

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to :Gijs (he/him) from comment #14)

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)

Just updated to today's build after the landing of this path, the issue of huge drop lists is back, so the problem is not fixed.
crash report: Firefox 108.0a1 Crash Report [@ webrender::render_api::window_size_sanity_check ]

Build ID 20221018094831
change set; https://hg.mozilla.org/mozilla-central/rev/826073b561e026d8fbc6a8354081db59727d9f33

A little more context in bug 1705002 - Jim, can you link to your crash report on crash-stats please?

Not sure how to link crash report, here are links to my crashes:
https://crash-stats.mozilla.org/report/index/558b1630-d095-4e70-a15a-5da060221018
https://crash-stats.mozilla.org/report/index/dccbe237-549d-4f85-98f9-f932a0221018
https://crash-stats.mozilla.org/report/index/af3a92db-dbe1-47ab-88f4-c80f30221018

Comment 19

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #17)

Oh, so a <select> menulist? That's useful, can try to repro. Also, what about the OS? Is this on Linux, macOS or Windows? Thanks again.

Oh, sorry - Windows 11 Home 22h2, fall release update for latest windows.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Can't reproduce that with something like this, which creates a very tall <select> list. The list is properly scrollable on macOS and Linux, at least, will check Windows in a bit:

<!doctype html>
<select id="s">
  <option>ABC</option>
</select>
<script>
  s.options.length = 9999;
</script>

Comment 21

[Emilio Cobos Álvarez (:emilio)]

Can't reproduce on windows, tried ~60k different options, and also I tried to make them really wide as well, with no avail. If you could privately mail me a way of accessing that page I'd be happy to dig into it, it may be due to some styling they use?

Comment 22

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #21)

Can't reproduce on windows, tried ~60k different options, and also I tried to make them really wide as well, with no avail. If you could privately mail me a way of accessing that page I'd be happy to dig into it, it may be due to some styling they use?

Email sent.

P.S. I don't know how to clear the list box on that site. The info there is not important so it could be deleted/removed or whatever, but I don't know how.