1710119 - Selected tab and tab hover feedback lack contrast in high contrast mode

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1710119 - Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbaece8a33d4
Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dbaece8a33d4

Comment 4

[Shilpa Mohanty]

Request for Uplift from the PM team

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9220861 [details]
Bug 1710119 - Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: Required for Proton / MR1
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enable High Contrast mode on Windows
  Make sure that there is proper visual feedback for the selected tab and for tab hover
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change
• String changes made/needed: none

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9220861 [details]
Bug 1710119 - Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry

Approved for 89 beta 12, thanks.

Comment 7

[Hani Yacoub, Desktop QA]

Attachment: HighContrastWindows.jpeg

I confirm that for tab select and tab hover whether they are pinned or normal there is a proper visual feedback while using high contrast on Windows 10 x64 and on Windows 7 x64 on Firefox Nightly 90.0a1 (2021-05-10).

Should this change be also reflected on open a new tab, list all tabs and on the navigation buttons? Please see the screenshot attached.

Comment 8

[Worcester12345]

(In reply to Hani Yacoub from comment #7)

Created attachment 9221279 [details]
HighContrastWindows.jpeg

I confirm that for tab select and tab hover whether they are pinned or normal there is a proper visual feedback while using high contrast on Windows 10 x64 and on Windows 7 x64 on Firefox Nightly 90.0a1 (2021-05-10).

Should this change be also reflected on open a new tab, list all tabs and on the navigation buttons? Please see the screenshot attached.

Is this the fixed or the broken picture? To me, I cannot tell where one tab ends and the next begins in this picture, even when enlarged.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b9303eb98db

Comment 10

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64 and on Windows 7 x64 on Firefox Beta 89.0b12.
The issue mentioned in comment 7 is still valid for Firefox Beta 89.0b12, I'm not sure if we should log a new bug for this.

Comment 11

[Hani Yacoub, Desktop QA]

Actually I observed another thing that I think its worth mentioning, these changes are only applicable with System Theme using the rest of the theme changes nothing.
Is the expected?