Closed Bug 1710119 Opened 7 months ago Closed 7 months ago

Selected tab and tab hover feedback lack contrast in high contrast mode

Categories

(Firefox :: Tabbed Browser, defect)

defect
Points:
1

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: dao, Assigned: dao, NeedInfo)

References

(Blocks 2 open bugs)

Details

(Keywords: access, Whiteboard: [proton-tabs-bar] [proton-uplift])

Attachments

(2 files)

No description provided.
Whiteboard: [proton-tabs-bar]
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbaece8a33d4
Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Request for Uplift from the PM team

Comment on attachment 9220861 [details]
Bug 1710119 - Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry

Beta/Release Uplift Approval Request

  • User impact if declined: Required for Proton / MR1
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Enable High Contrast mode on Windows
    Make sure that there is proper visual feedback for the selected tab and for tab hover
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only change
  • String changes made/needed: none
Attachment #9220861 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9220861 [details]
Bug 1710119 - Improve contrast of the selected tab and tab hover feedback in high contrast mode. r=harry

Approved for 89 beta 12, thanks.

Attachment #9220861 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I confirm that for tab select and tab hover whether they are pinned or normal there is a proper visual feedback while using high contrast on Windows 10 x64 and on Windows 7 x64 on Firefox Nightly 90.0a1 (2021-05-10).

Should this change be also reflected on open a new tab, list all tabs and on the navigation buttons? Please see the screenshot attached.

Flags: needinfo?(dao+bmo)

(In reply to Hani Yacoub from comment #7)

Created attachment 9221279 [details]
HighContrastWindows.jpeg

I confirm that for tab select and tab hover whether they are pinned or normal there is a proper visual feedback while using high contrast on Windows 10 x64 and on Windows 7 x64 on Firefox Nightly 90.0a1 (2021-05-10).

Should this change be also reflected on open a new tab, list all tabs and on the navigation buttons? Please see the screenshot attached.

Is this the fixed or the broken picture? To me, I cannot tell where one tab ends and the next begins in this picture, even when enlarged.

Verified as fixed on Windows 10 x64 and on Windows 7 x64 on Firefox Beta 89.0b12.
The issue mentioned in comment 7 is still valid for Firefox Beta 89.0b12, I'm not sure if we should log a new bug for this.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

Actually I observed another thing that I think its worth mentioning, these changes are only applicable with System Theme using the rest of the theme changes nothing.
Is the expected?

Whiteboard: [proton-tabs-bar] → [proton-tabs-bar] [proton-uplift]
You need to log in before you can comment on or make changes to this bug.