1710126 - More PropertyDescriptor cleanups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710126 - Remove setGetter/setSetter. r?jandem

Depends on D114595

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710126 - Make PropertyDescriptor attrs private. r?jandem

Depends on D114635

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710126 - Make PropertyDescriptor getter and setter private. r?jandem

Depends on D114636

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41ba96d381e4
Remove setGetter/setSetter. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3f1f2606b45f
Make PropertyDescriptor attrs private. r=jandem
https://hg.mozilla.org/integration/autoland/rev/2a4d6457ef7e
Make PropertyDescriptor getter and setter private. r=jandem

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710126 - Create complete AccessorDescriptors. r?jandem

Comment 6

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710126 - Use the PropertyDescriptor constructors for NativeGetOwnPropertyDescriptor. r?jandem

I am not sure if we should preserve parts of the accessor comment, because
the constructor always create complete descriptor now.

In the future switching GetPropertyAttributes to return JS::PropertyAttributes
seems like a good idea.

Depends on D114838

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/41ba96d381e4
https://hg.mozilla.org/mozilla-central/rev/3f1f2606b45f
https://hg.mozilla.org/mozilla-central/rev/2a4d6457ef7e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4230a851bd5
Create complete AccessorDescriptors. r=jandem
https://hg.mozilla.org/integration/autoland/rev/99bb49a1cf89
Use the PropertyDescriptor constructors for NativeGetOwnPropertyDescriptor. r=jandem

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e4230a851bd5
https://hg.mozilla.org/mozilla-central/rev/99bb49a1cf89