1710249 - Use SeaMonkey theme secure icons in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

Once Bug 1710248 lands should be able to use SeaMonkey secure icons for the cZ security button.

Comment 1

[Ian Neal]

Attachment: 1710249-irc-secure-icons-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9220980 [details] [diff] [review]
1710249-irc-secure-icons-2539.patch

LGTM but there is room for a followup.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: Capture.PNG

Above one is the browser status bar (S is NoScript). Lower one cZ.

Order is different so maybe do a followup of bug 1710233 and move notificaction and logging buttions to the left. Then switch offline and secure.
Also styling is different. No green icon for secure. In the browser the text box is only shown for eV certificates using a more saturated green. title bar seems to show the topic so wonder if we shouldn't just show server and channel here.

Anayway good for a followup and discussion first.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/98c7a80cde17
Use SeaMonkey theme secure icons in cZ. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/29178146122cd37f0d63a90bc4816f90a0ffedd0
Use SeaMonkey theme secure icons in cZ. r=frg a=frg