1710407 - Autofill address/credit card dialogs are unnecessarily scrollable

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[:Gijs (he/him)]

The 6px padding on :root added in bug 1705330 is causing these dialogs to scroll by 12px vertically.

I don't really understand why, off-hand - perhaps the scrollHeight for the document isn't taking the padding into account, and we should be adding the padding to body instead, for the HTML dialog case? I also noticed that bug 1684530 solved the same problem as bug 1705330 but only for the autofill dialogs.

These kinds of bugs would stand a better chance of not being introduced if these features were default-enabled...

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1710407 - fix unnecessary scrollbars in address/creditcard dialogs in the settings, r?jaws

Comment 2

[:Gijs (he/him)]

I messed up the initial tracking flags here, this doesn't affect 89 anyways, because the regressing bug, bug 1705330, wasn't uplifted.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/217eac223b79
fix unnecessary scrollbars in address/creditcard dialogs in the settings, r=jaws,preferences-reviewers

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/217eac223b79

Comment 5

[Giorgia Nichita, Release Desktop QA]

I have reproduced this on an affected Nightly build 90.0a1 (2021-05-10)

Confirming this issue as verified fixed on Win 10x64, Ubuntu 20.04 and macOS 10.15, using Firefox 90.0b5 (2021-06-08).
Thanks!