1710436 - [Wayland] Better popup dependency handling

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Martin Stránský [:stransky] (ni? me)]

We need better popup handling when there are different popup classes opened.

• When a top level notification popup is opened (web notification, geolocation confirmation), we can't close this popup. When a new menu popup is opened, we can't use move_to_rect function to position it due to xgd_positioner limitation (popup surfaces must overlap). So use plain gtk_window_move() here.

• When a top level notification popup is opened and another panel (hamburger menu) is opened, use the gtk_window_move(). We need to use gtk_window_move() any time when a popup is opened but its child popup (a) can't be closed (b) does not belong to popups parent from layout perspective.

• When a popup (a) is opened (with auto-close enabled) and another popup (b) is opened from different popup hierarchy, close the popup (a) first and then open popup (b) with move_to_rect.

This should handle all possible popup scenarios.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1710436 [Wayland] Rework Wayland popup hierarchy, r?jhorak

• Keep strong popup hierarchy for every toplevel nsWindow.
• Divide popups to tracked and non-tracked. Tracked popups are tracked in popup hierarchy for every toplevel window. Non-tracked popups are handled as X11 ones.
• Map non-tracked popups as wl_surfaces and use gtk_window_move() on them.
• Map tracked popups as xdg_popups and use gtk_window_move_to_rect() on them.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Testcase:

https://palegreendot.co.uk/collections/fresh-alcohol-fortnightly/products/premium-veg-box-fortnightly-subscription?selling_plan=441122970&variant=37737131016346

• Keep the location popup open, try to open hamburger menu, content menus, extensions (remote) popups.
• Open popups from URL bar - permissions popups.
• Open Bookmark popup,Pocket popup, click away and open content menu

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84818e46d11d
[Wayland] Rework Wayland popup hierarchy, r=jhorak

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 84818e46d11d (bug 1710436) for Mochitest failures in toolkit/content/tests/chrome/test_panel.xhtml. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=340930403&repo=autoland&lineNumber=9017

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=84818e46d11dcbf435aed65951413dbd4b29ddf2

Backout:
https://hg.mozilla.org/integration/autoland/rev/b1d195d012a4af03c9cd001af57bc3d4d95396cd

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a30d9e69dc
[Wayland] Rework Wayland popup hierarchy, r=jhorak

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b4a30d9e69dc

Comment 9

[Jonny Mako]

This is another related regression/breakage
https://bugzilla.mozilla.org/show_bug.cgi?id=1710770