1710582 - refreshTab test helper should support target switching

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

This helper currently only track document's load, whereas it should also track panel's updates and wait for the new top level target to be processed.
It becomes important once we enable JSWindowActor based target in bug 1698891.

Note that debugger is also having its own helper, which we may try to merge with the more generic one:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/test/mochitest/helpers.js#783-790

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1710582 - [devtools] Make refreshTab test helper wait for target switching.

navigateTo contains all the logic to wait for panel updates on reload,
as well as wait for the process of the new target.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1710582 - [devtools] Make debugger test helper use refreshTab.

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

(In reply to Alexandre Poirot [:ochameau] from comment #0)

Note that debugger is also having its own helper, which we may try to merge with the more generic one:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/test/mochitest/helpers.js#783-790

About this, this is actually more complex as the debugger often hit a breakpoint on reload and block the page load.
For example BrowserTestUtils.browserLoaded won't resolve because of this.
It makes it hard to reuse navigateTo and know what event to wait for.

Comment 4

[Alexandre Poirot [:ochameau] [PTO back August 21]]

This is involved into devtools/client/inspector/test/browser_inspector_select-last-selected.js (at least this test) failure with bfcache in parent.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d503af62f44b
[devtools] Make refreshTab test helper wait for target switching. r=nchevobbe

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d503af62f44b