1710729 - [X11/EGL] EGLSurface Regression with WebRender on Linux with proprietary NVIDIA

Status: RESOLVED DUPLICATE of bug 1646135

(Core :: Graphics: WebRender, defect)

Description

[Tony Stipanic]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

1. Force enable WebRender by setting gfx.webrender.all to true
2. Restart Firefox
3. Check Compositor in about:support

Actual results:

Compositor is either WebRender (software) on current Nightly releases or is Basic for the current released version 88.0.1

Expected results:

Compositor is set as WebRender

There seems to be a regression as versions before 88 work fine with the proprietary NVIDIA driver 465.27. This change happened exactly with a commit that actually fixed Bug 1684194 as found out via mozregression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=de1a1b350e9e0fb606cc7f5b709df544af8dd313&tochange=52299c7cbec44f2fe75273acdf2aed8e2496931c

Comment 1

[Tony Stipanic]

Additional information:

Error log:

[GFX1-]: Failed to create EGLSurface!: 0x3009
[GFX1-]: Failed to create EGLSurface
[GFX1-]: Fallback (SW-)WR to Basic
[GFX1-]: Compositors might be mixed (5,1)
[GFX1-]: Failed to connect WebRenderBridgeChild.
IPDL protocol error: Handler returned error code!

###!!! [Parent][DispatchSyncMessage] Error: PCompositorBridge::Msg_NotifyChildRecreated Processing error: message was deserialized, but the handler returned false (indicating failure)

[GFX1-]: Failed to connect WebRenderBridgeChild.

OS: Manjaro Linux
KDE Version: 5.21.5
Graphics: NVIDIA GeForce GTX 1070 with NVIDIA 465.27

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Robert Mader [:rmader]]

Tony, are you sure that you don't have the MOZ_X11_EGL env variable set? Because it looks a lot like it. If that's the case, then it's not really a regression - prop. nvidia is not yet supported for the EGL backend.

Comment 4

[Tony Stipanic]

Of course! My mistake, I didn't clarify that I did set the MOZ_X11_EGL environment variable. I'm going to attach two files containing the raw about:support for both good and bad build just to show that X11 EGL is force set by envvar for both versions

Comment 5

[Tony Stipanic]

Attachment: Raw about:support result from bad build

Comment 6

[Tony Stipanic]

Attachment: Raw about:support result from working build

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Yes, NVIDIA binary drivers are not working with EGL backend.

Comment 8

[Tony Stipanic]

Right, I get what you mean. Thanks for taking your time!

Since binary drivers don't support RenderCompositorEGL specifically, is there actually a possibility to work around this so it doesn't use this specific backend if binary drivers have been detected?

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Yes, we need some kind of detection here. We'll look at it when we switch to EGL by default and fallback to GLX/X11 on NV drivers.