1710835 - Even more PropertyDescriptor work

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Add convenience getters to PropertyAttributes. r?jandem

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Correct rooting for PropertyDescriptor::value. r?jandem

Depends on D114962

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Use PropertyAttributes for NativeDefineProperty. r?jandem

This also changes GetPropertyAttributes to return JS::PropertyAttributes.

I also introduced a specialized GetExistingDataProperty variant. We actually
have to handle the isDataProperty() case before isHelperThreadContext assert,
because apparently stencil calls this on the helper thread...

Depends on D114963

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f0350464015
Add convenience getters to PropertyAttributes. r=jandem
https://hg.mozilla.org/integration/autoland/rev/afa92815630f
Correct rooting for PropertyDescriptor::value. r=jandem
https://hg.mozilla.org/integration/autoland/rev/8257bbb07294
Use PropertyAttributes for NativeDefineProperty. r=jandem

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Add PropertyDescriptor::Empty constructor. r?jandem

Comment 6

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Use PropertyDescriptor::Data in one more place. r?jandem

Depends on D115370

Comment 7

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Remove PropertyDescriptor setAttributes. r?jandem

Depends on D115371

Comment 8

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1710835 - Remove PropertyDescriptor setDataDescriptor. r?jandem

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fa3b767c6b3
Add PropertyDescriptor::Empty constructor. r=jandem
https://hg.mozilla.org/integration/autoland/rev/65de7e6a9c6c
Use PropertyDescriptor::Data in one more place. r=jandem
https://hg.mozilla.org/integration/autoland/rev/7894ebeb1ffa
Remove PropertyDescriptor setAttributes. r=jandem

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3f0350464015
https://hg.mozilla.org/mozilla-central/rev/afa92815630f
https://hg.mozilla.org/mozilla-central/rev/8257bbb07294

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1fa3b767c6b3
https://hg.mozilla.org/mozilla-central/rev/65de7e6a9c6c
https://hg.mozilla.org/mozilla-central/rev/7894ebeb1ffa

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eb34c76cf73
Remove PropertyDescriptor setDataDescriptor. r=jandem

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7eb34c76cf73