1710891 - Link to download full build from About dialog is broken

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[ian.henderson]

Attachment: Automatic update

+++ This bug was initially created as a clone of Bug #1710890 +++

When I try to update from the autoupdate the URL https://www.mozilla.org/en-GB/sco/firefox/channel/desktop/#nightly does not appear to be correct.

Comment 1

[Francesco Lodolo [:flod]]

For reference:

• This happens when the update installation fails, and the about dialog displays a link to download a new build.
• This is a sco build, which doesn't have localized pages on mozilla.org, and has an accept-languages header set as sco,en-GB,en.

So, I would expect Firefox to ask for https://www.mozilla.org/firefox/channel/desktop/#nightly. Since sco is not available, it should fall back to en-GB. If I manually set intl.accept_languages to sco,en-GB,en and open the locale agnostic URL in the browser, it works as expected.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

(In reply to Francesco Lodolo [:flod] from comment #1)

So, I would expect Firefox to ask for https://www.mozilla.org/firefox/channel/desktop/#nightly. Since sco is not available, it should fall back to en-GB. If I manually set intl.accept_languages to sco,en-GB,en and open the locale agnostic URL in the browser, it works as expected.

Are you sure that that is the behavior that we want here? The page is arguably localized correctly, but the download link will be for the en-GB version of Firefox, not the sco version of Firefox.

Comment 3

[Francesco Lodolo [:flod]]

That's not the behavior we want, that's the best that we can get right now.

There have discussions around it for MR1, but considered out of scope. IMO, the link should just download the same build as the one used by the user. In case, Romain would be the person to talk to about scoping and fixing this properly.

Comment 4

[Nick Rishel [:nrishel]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1730110#c2 suggests a solution to a tangential problem that would allow for the language granularity needed here, at the cost of being directed to a page which isn't reengaging. Maybe that's less necessary for nightly, where there's more risk of mismatch between mozilla.org and Firefox locales?

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Nick Rishel from comment #4)

Maybe that's less necessary for nightly, where there's more risk of mismatch between mozilla.org and Firefox locales?

I don't think the risk is that smaller outside of Nightly: population is larger, and we have plenty of locales falling back with localization of mozilla.org (or not being there at all).

Comment 6

[Paul [:pmac] McLanahan]

Thanks for the ping. I think the original bug should be fixed now since the website does now support the sco locale, but this page isn't translated into sco so they would still just get the en-GB version of the page, and thus the en-GB version of the browser. We could send them to https://www.mozilla.org/en-US/firefox/all/#product-desktop-nightly instead so they can select their language, but that page can be confusing to some because of all of the choices of browser and platform.

Comment 7

[Nick Rishel [:nrishel]]

Closing as the original bug was fixed when the sco locale was added to bedrock. Follow up bug report for locale download mismatch opened here - https://bugzilla.mozilla.org/show_bug.cgi?id=1751271.