1710941 - Avoid showing "Unknown content" dialog for download, unless user spefically set it

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, enhancement, P3)

Description

[Micah [:mtigley] (she/her)]

We want to avoid always prompting the user with the "What should Firefox do with this file" dialog when initiating a download, unless the user has "always ask" set to true. If the user has "always ask" set to true, then we should always prompt them with the download filepicker (even if they have a specific file type set to "always open with X").

Currently, we have two variables preferredAction and alwaysAskBeforeHandling to indicate whether or not we prompt the user.

Comment 1

[Ava Katushka]

Does it mean we don't want to show the dialog ever?
How we decide what to do with file: save to the folder, open with app?

Comment 2

[Micah [:mtigley] (she/her)]

(In reply to Ava Katushka from comment #1)

Does it mean we don't want to show the dialog ever?

We only want to set the default option to "Save to Disk" for the unknownContentTypeWindow dialog (i.e: the dialog displayed when handling LaunchWithApplication downloads). And we only want to show it when the "Always Ask" option is enabled from about:preferences under the "Files and Applications" section. Setting this preference from there also sets the "browser.download.useDownloadDir" to false, so that means we might have to check that "browser.download.useDownloadDir" is true before deciding whether or not we show it.

How we decide what to do with file: save to the folder, open with app?

With the current plan, neither of those options will be available to the user since the user is no longer prompted, and will instead save the file directly to disk. I think this is fine since those options are available to the user when the "Always Ask" option is enabled.

So to summarize: if the user doesn't have their downloads set to "always ask" we just save to disk. We may add the option to open the file automatically (see bug 1711053) to handle the case where the user wants to launch the file after it's finished.

Comment 3

[Ava Katushka]

Attachment: Bug 1710941 - Show UnknownContentType dialog only if user set alwaysAsk to true. r?mtigley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fc41ac00d90
Show UnknownContentType dialog only if user set alwaysAsk to true. r=mtigley

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in browser_download_skips_dialog

Backout link: https://hg.mozilla.org/integration/autoland/rev/ae2d4704c3a7a00708d4bc873d4578ec21ecd6a7

Push with failures

Failure log

Comment 6

[Micah [:mtigley] (she/her)]

It looks like there a race between opening the new tab and when we shut down the test. We'll have to make sure that the new tab is finished opening once the download has finished.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ebb5912bb0e
Show UnknownContentType dialog only if user set alwaysAsk to true. r=mtigley

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4ebb5912bb0e