Closed Bug 1711164 Opened 3 years ago Closed 3 years ago

Intermittent Assertion failure: false (MOZ_ASSERT_UNREACHABLE: No/wrong surface in container!), at /builds/worker/checkouts/gecko/image/Image.cpp:327

Categories

(Core :: Graphics: ImageLib, defect, P5)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: aosmond)

References

(Regression)

Details

(Keywords: assertion, intermittent-failure, regression)

Attachments

(1 file)

Bug 1711164 - Ensure we never use cached surfaces with blob recordings.
48 bytes, text/x-phabricator-request
Details | Review

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=339661528&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aCb4d9e3RB6XJ-32ASuIIQ/runs/0/artifacts/public/logs/live_backing.log

[task 2021-05-14T00:42:32.717Z] 00:42:32     INFO - TEST-START | layout/base/tests/test_reftests_with_caret.html
[task 2021-05-14T00:42:32.730Z] 00:42:32     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:179
[task 2021-05-14T00:42:32.752Z] 00:42:32     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:179
[task 2021-05-14T00:42:33.276Z] 00:42:33     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:449
[task 2021-05-14T00:42:33.386Z] 00:42:33     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:449
[task 2021-05-14T00:42:33.411Z] 00:42:33     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
[task 2021-05-14T00:42:33.412Z] 00:42:33     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:33.413Z] 00:42:33     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
[task 2021-05-14T00:42:33.414Z] 00:42:33     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:35.999Z] 00:42:35     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/dom/events/ContentEventHandler.cpp:1895
[task 2021-05-14T00:42:36.000Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: 'queryTextRectsEvent.Failed()', file /builds/worker/checkouts/gecko/widget/ContentCache.cpp:285
[task 2021-05-14T00:42:36.001Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!QueryCharRectArray(aWidget, startOffset, length, rects)', file /builds/worker/checkouts/gecko/widget/ContentCache.cpp:350
[task 2021-05-14T00:42:36.129Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:449
[task 2021-05-14T00:42:36.129Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(aNextContent && aRange) failed: file /builds/worker/checkouts/gecko/editor/spellchecker/FilteredContentIterator.cpp:240
[task 2021-05-14T00:42:36.134Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: 'charRects.IsEmpty()', file /builds/worker/checkouts/gecko/dom/events/ContentEventHandler.cpp:1895
[task 2021-05-14T00:42:36.231Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:449
[task 2021-05-14T00:42:36.232Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(aNextContent && aRange) failed: file /builds/worker/checkouts/gecko/editor/spellchecker/FilteredContentIterator.cpp:240
[task 2021-05-14T00:42:36.237Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: 'charRects.IsEmpty()', file /builds/worker/checkouts/gecko/dom/events/ContentEventHandler.cpp:1895
[task 2021-05-14T00:42:36.262Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
[task 2021-05-14T00:42:36.263Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:36.264Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
[task 2021-05-14T00:42:36.265Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:36.303Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:449
[task 2021-05-14T00:42:36.580Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: '!aChild->IsContent()', file /builds/worker/workspace/obj-build/dist/include/mozilla/EditorDOMPoint.h:449
[task 2021-05-14T00:42:36.605Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
[task 2021-05-14T00:42:36.606Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:36.608Z] 00:42:36     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
<...>
[task 2021-05-14T00:42:40.098Z] 00:42:40     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:40.100Z] 00:42:40     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:453
[task 2021-05-14T00:42:40.101Z] 00:42:40     INFO - GECKO(9812) | [Child 5240, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1180
[task 2021-05-14T00:42:41.681Z] 00:42:41     INFO - GECKO(9812) | [2021-05-14T00:42:41Z WARN  webrender::device::gl] Missing optimized shader source for gpu_cache_update
[task 2021-05-14T00:42:47.808Z] 00:42:47     INFO - GECKO(9812) | [Child 5456, Main Thread] WARNING: '!aContent->GetComposedDoc()', file /builds/worker/checkouts/gecko/layout/base/nsCSSFra[CmeChonstirulcd t52or.cpp:8427
[task 2021-05-14T00:42:47.809Z] 00:42:47     INFO - GECKO(9812) | 40, Main Thread] WARNING: '!aContent->GetComposedDoc()', file /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:8427
[task 2021-05-14T00:42:47.813Z] 00:42:47     INFO - GECKO(9812) | Assertion failure: false (MOZ_ASSERT_UNREACHABLE: No/wrong surface in container!), at /builds/worker/checkouts/gecko/image/Image.cpp:327
[task 2021-05-14T00:42:47.847Z] 00:42:47     INFO - GECKO(9812) | [Child 5456, Main Thread] WARNING: '!aContent->GetComposedDoc()', file /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:8427
[task 2021-05-14T00:42:47.848Z] 00:42:47     INFO - GECKO(9812) | [Child 5456, Main Thread] WARNING: '!aContent->GetComposedDoc()', file /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:8427
[task 2021-05-14T00:42:47.897Z] 00:42:47     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2021-05-14T00:42:56.782Z] 00:42:56     INFO - GECKO(9812) | #01: mozilla::image::ImageResource::UpdateImageContainer(mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > const&) [image/Image.cpp:327]
[task 2021-05-14T00:42:56.783Z] 00:42:56     INFO - GECKO(9812) | #02: mozilla::image::VectorImage::SendInvalidationNotifications() [image/VectorImage.cpp:525]```
Flags: needinfo?(aosmond)
Regressed by: 1704792
Has Regression Range: --- → yes

I think I know what this is.

Flags: needinfo?(aosmond)
Assignee: nobody → aosmond

We don't support storing blob recordings in the surface cache at this
time so we should never look at it. It is possible that one may request
a blob recording, and have a previous rasterization available in the
cache because it was used in canvas or as a repeating background image.
We want to explicitly avoid the cache in that case.

Set release status flags based on info from the regressing bug 1704792

status-firefox88: --- → unaffected
status-firefox89: --- → unaffected
status-firefox90: --- → affected
status-firefox-esr78: --- → unaffected
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66200d07c1d1
Ensure we never use cached surfaces with blob recordings. r=gfx-reviewers,nical
Blocks: 1711328

Backed out changeset 66200d07c1d1 (bug 1711164) for browser-chrome failures in browser/base/content/test/performance/browser_preferences_usage.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=339906884&repo=autoland&lineNumber=2000

Push with failues:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=66200d07c1d1b3c0c7aebba03345c0dbb19b4fb3

Backout:
https://hg.mozilla.org/integration/autoland/rev/51268fe90cb7c403b86813cfc9486c4c62b1d22d

Flags: needinfo?(aosmond)

Probably we end up drawing a little more because of caching differences.

Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7811b10f32a1
Ensure we never use cached surfaces with blob recordings. r=gfx-reviewers,nical

Grrr. Let's try this again.

Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de598771f8a6
Ensure we never use cached surfaces with blob recordings. r=gfx-reviewers,nical

https://hg.mozilla.org/mozilla-central/rev/de598771f8a6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: