1711259 - Use the correct menulist > menupopup padding for -moz-proton-contextmenus

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The menulist > menupopup needs more padding on the left under Windows 10.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1711259-menulist-popup-padding.patch

This should fix it.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9221990 [details] [diff] [review]
1711259-menulist-popup-padding.patch

Review of attachment 9221990 [details] [diff] [review]:
-----------------------------------------------------------------

The padding looks good but the extra CSS at the end confuses me a bit.

::: mail/themes/windows/mail/themeableDialog.css
@@ +65,5 @@
> +  menulist > menupopup > menuitem > .menu-iconic-left,
> +  menulist > menupopup > menu > .menu-iconic-left {
> +    display: -moz-box;
> +  }
> +}

Sorry, but I don't understand these changes to the CSS.

If we're not in Proton, the menu-iconic-left has a display of -moz-box.
But also if we're in proton it has it, but only if not in Windows 10?
Also why the double `not (-moz-os-version: windows-win10), (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0)`?
What's the condition here?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani [:aleca] from comment #2)

First, the -moz-proton-contextmenus applies only on Windows with default theme and not on all other Windows versions and not on High Contrast. And yes, it's complicated to support all this Windows versions.

Sorry, but I don't understand these changes to the CSS.

If we're not in Proton, the menu-iconic-left has a display of -moz-box.

Correct, this is the pre-proton behaviour .

But also if we're in proton it has it, but only if not in Windows 10?

Yes

Also why the double not (-moz-os-version: windows-win10), (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0)?
What's the condition here?

The not (-moz-os-version: windows-win10) is for all Windows versions other than Win 10.
The (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0) is for Windows 10 High Contrast.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9221990 [details] [diff] [review]
1711259-menulist-popup-padding.patch

I hope you understand now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/39b5b929f153
Use the correct menulist > menupopup padding for -moz-proton-contextmenus. r=aleca