Closed Bug 1711259 Opened 3 years ago Closed 3 years ago

Use the correct menulist > menupopup padding for -moz-proton-contextmenus

Categories

(Thunderbird :: Theme, task)

Unspecified
Windows

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

The menulist > menupopup needs more padding on the left under Windows 10.

This should fix it.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9221990 - Flags: review?(alessandro)
Comment on attachment 9221990 [details] [diff] [review]
1711259-menulist-popup-padding.patch

Review of attachment 9221990 [details] [diff] [review]:
-----------------------------------------------------------------

The padding looks good but the extra CSS at the end confuses me a bit.

::: mail/themes/windows/mail/themeableDialog.css
@@ +65,5 @@
> +  menulist > menupopup > menuitem > .menu-iconic-left,
> +  menulist > menupopup > menu > .menu-iconic-left {
> +    display: -moz-box;
> +  }
> +}

Sorry, but I don't understand these changes to the CSS.

If we're not in Proton, the menu-iconic-left has a display of -moz-box.
But also if we're in proton it has it, but only if not in Windows 10?
Also why the double `not (-moz-os-version: windows-win10), (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0)`?
What's the condition here?
Attachment #9221990 - Flags: review?(alessandro)

(In reply to Alessandro Castellani [:aleca] from comment #2)

First, the -moz-proton-contextmenus applies only on Windows with default theme and not on all other Windows versions and not on High Contrast. And yes, it's complicated to support all this Windows versions.

Sorry, but I don't understand these changes to the CSS.

If we're not in Proton, the menu-iconic-left has a display of -moz-box.

Correct, this is the pre-proton behaviour .

But also if we're in proton it has it, but only if not in Windows 10?

Yes

Also why the double not (-moz-os-version: windows-win10), (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0)?
What's the condition here?

The not (-moz-os-version: windows-win10) is for all Windows versions other than Win 10.
The (-moz-os-version: windows-win10) and (-moz-windows-default-theme: 0) is for Windows 10 High Contrast.

Comment on attachment 9221990 [details] [diff] [review]
1711259-menulist-popup-padding.patch

I hope you understand now.

Attachment #9221990 - Flags: review?(alessandro)
Attachment #9221990 - Flags: review?(alessandro) → review+
Target Milestone: --- → 90 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/39b5b929f153
Use the correct menulist > menupopup padding for -moz-proton-contextmenus. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: