1711270 - Fix typo in function name of updateAriaLabelsOfAddressRow()

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Description

[Thomas D. (:thomas8)]

Thanks to :darktrojan for finding this, good catch!
As discussed on Matrix today, this function was born with a typo (wasn't me...):

https://searchfox.org/comm-central/rev/0d91887877be667c7253890a21dfe1806bdbfe4a/mail/components/compose/content/MsgComposeCommands.js#4197
function udpateAddressingInputAriaLabel(row) {

Two commits later, everyone including myself still never saw the typo in spite of touching the function name.

https://searchfox.org/comm-central/rev/b8dec9127eaa897dd3f4cd1cd0d151b015df2b43/mail/components/compose/content/MsgComposeCommands.js#4449

async function udpateAriaLabelsOfAddressRow(row) {

Time to nitfix this once and for all!

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1711270_fixtypo_updateAriaLabelsOfAddressRow.diff

Fix the typo.

Comment 2

[Alessandro Castellani [:aleca]]

As discussed on Matrix today, this function was born with a typo (wasn't me...):

That was a beautiful Easter egg I left on purpose...yeah...definitely on purpose...

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9222009 [details] [diff] [review]
1711270_fixtypo_updateAriaLabelsOfAddressRow.diff

Thanks for fixing. I would never make such a ridiculous mistake!

Comment 4

[Thomas D. (:thomas8)]

Alright, let me summarize for the sake of order and QA:

• Per Aleca's comment 2, this was a beautiful easter egg left on purpose.
• Per Geoff's comment 3, it would appear that the egg theory has been crushed, so it's now scrambled egg at best...
• Strangely, eval("comment 2 || comment 3") returns false! Something is fishy here! I am seeing elements of diversionary tactics!

So what's the way forward? File a followup bug, "Add developer polygraph test to BMO comment linter"!?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1934a66dc57e
Fix typo in function name of updateAriaLabelsOfAddressRow(). r=darktrojan

Comment 6

[Thomas D. (:thomas8)]

Fwiw, TB 78 is probably wontfix, but not unaffected as it does have the original typo (inconsequential):
https://hg.mozilla.org/releases/comm-release/file/9921e1929e744e2f5e64163f036c215f2960fc1f/mail/components/compose/content/MsgComposeCommands.js#l4137
function udpateAddressingInputAriaLabel(row) {

(copied over mkmelin's flag change from my identical Bug 1710825 Comment 10 which was in the wrong place)