1711375 - Use Unicode instead of images for smilies in chatZilla

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

Rather than use images for the smilies in cZ switch to using Unicode and the bundle emoji font.

Comment 1

[Ian Neal]

Attachment: 1711375-irc-smiley-unicode-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: Capture.PNG

The patch is now for some time in the b1 pre version and I am really not a fan. While technically the right thing to do it did not grow on me :)

The unicode icon is too small and I have a hard time actually seeing what the smilie is about. Not sure if it would be easy to adjust the font size? It also includes a line break in the text. Do we want to go forward in the current state or rethink?

Comment 3

[Ian Neal]

Attachment: 1711375-irc-smiley-unicode-v1_1-2539.patch

Changes since last patch:

• Fixed issue with smiley being on a separate line to other text;
• Made font size for smiley larger than parent via css;
• Fixed issue with space either side of smiley being swallowed.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9229654 [details] [diff] [review]
1711375-irc-smiley-unicode-v1_1-2539.patch

Still a bit on the smallish side in Windows 8.1 but much better. Possible enhancements in a followup if needed I think.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/04b6c58d03ea
Use Unicode instead of images for smilies in chatZilla. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/76630e369f5db08289389cc041e72cec6112aa6a
Use Unicode instead of images for smilies in chatZilla. r=frg a=frg