1711376 - Add some extra emojis to chatZilla

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

At the moment there is a fairly limited set of smilies in chatZilla, now we have switched to Unicode / emoji font it should be fairly simple to add some more.

Comment 1

[Ian Neal]

Attachment: WIP-1711376-irc-extra-smilies-2539.patch

At the moment added:
Innocent
Kissing
Smile with Sweat
Worried
Woozy
Zipped

See https://www.emoticonr.com/emoticons and https://en.wikipedia.org/wiki/List_of_emoticons for potential other options.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9222074 [details] [diff] [review]
WIP-1711376-irc-extra-smilies-2539.patch

Just tried a few based on https://en.wikipedia.org/wiki/List_of_emoticons and they worked. Some combinations did not but that is expected.

r/a+ and happy to put this in unless you want to fine tune further.

Comment 3

[Ian Neal]

Comment on attachment 9222074 [details] [diff] [review]
WIP-1711376-irc-extra-smilies-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: less emojis
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Extra linefeed after type = "face-zipped"; can be removed on checkin please?

Happy for more combinations to be added, but that can be another patch / bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d885e4c0873
Add some extra smilies to chatZilla. r=frg

Comment 5

[Ian Neal]

Comment on attachment 9222074 [details] [diff] [review]
WIP-1711376-irc-extra-smilies-2539.patch

[Triage Comment]
Marking r/a for frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/6faf96d9e0788819503d037dd74a93dfc700b0db
Add some extra smilies to chatZilla. r=frg a=frg