1711411 - When I reopen a closed tab by right clicking on a currently open tab, I get unexpected behavior

Status: RESOLVED DUPLICATE of bug 1703518

(Core :: Widget: Cocoa, defect, P2)

Description

[Chris Karlof [:ckarlof]]

Attachment: Screen recording of problem (limited to Mozilla internal)

It reopens the tab I right clicked on in a new window (see the screen recording). When I right click on an empty part of the tab bar to do this operation, I get the expected results (it re-opens in the same window). I have also experienced some similar problems when pinning tabs (I get similar unexpected results). I can create some screen recordings of that situation too if it would be helpful.

This was reproduced in a new profile on Nightly Fx 90, build id 20210516091748.

Comment 1

[Robert Martin [:romartin], Ecosystem QA]

We've managed to reproduce the issue using the latest Nightly 90.0a1 (Build ID: 20210527212801) on macOS 11.3.1

[Precondition]:

• Have a new Nightly profile created.

[Steps to Reproduce]:

1. Open the browser.
2. Open a "New tab" page and navigate to "google.com".
3. Close the "google.com" tab.
4. Open the Tab context menu using the "control ^" key + click on an opened tab.
5. Select the "Reopen Closed Tab" option and observe the behavior.

[Expected result]:

• The last closed tab is reopened as a New Tab.

[Actual result]:

• The last closed tab is reopened as a New Window.

[Notes]:

• We did not manage to reproduce the issue using macOS 10.15.x.

Comment 2

[krupa raj [:krupa--use this to needinfo]]

This behavior seems like something we should fix. Dao, can you take a look pls?

Comment 3

[Robert Martin [:romartin], Ecosystem QA]

Hello,

Using the Mozregression tool I've managed to find the following regression range:

• Last good revision: 368bc78b72f16ce7752b25cc6e342a2299f80eab
• First bad revision: 1bbaffb1aa84e4fc7ba52bb1f06443448e9316d9
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=368bc78b72f16ce7752b25cc6e342a2299f80eab&tochange=1bbaffb1aa84e4fc7ba52bb1f06443448e9316d9

The result of the regression range points towards the bug being regressed by the implementation of bug 1700679. @Markus, can you please weigh in on this?

Comment 4

[Robert Martin [:romartin], Ecosystem QA]

Given the above results:

• I've changed the component to the one where the bug that caused the regression is.
• I've also changed the flag for "Firefox 91" to "affected" and left the "Firefox 90" flag as "affected" but with a caveat:
  • I cannot reproduce the issue using the Firefox 90.0b1 Beta build or with the Firefox 89.0 Release build. However, I can reproduce the issue using Firefox Nightly 90.0a1 and Firefox Nightly 91.0a1 builds.