1711418 - Add the OOMAllocationSize field to crashes captured by WER

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

This requires reading the crashed process memory so we'll have to add a pointer to the allocation to the data we pass to the WER runtime exception module. It might be useful to fix bug 1709277 first but not strictly necessary.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1711418 - Factorize the code that reads/writes memory to/from other processes r=KrisWright

Depends on D116017

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1711418 - Record the OOM allocation size in WER crashes r=KrisWright

This patch adds a new field to the structures that WER reads from a
crashed process. This field contains a pointer to the global variable
that records the size of the last failed annotation.

When WER intercepts a crash it will use this address to read the
variable. If it's not zero it will add the corresponding annotation
to the crash report.

Depends on D116449

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02cf2dc4c3c8
Factorize the code that reads/writes memory to/from other processes r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/4cc2cb3653f2
Record the OOM allocation size in WER crashes r=KrisWright

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (Bug 1697895, Bug 1682518, Bug 1703761, Bug 1711418) for causing Windows 2012 x64 asan build bustages.
https://hg.mozilla.org/integration/autoland/rev/f4046bbf47c7b1b2f596168b3ffa7f046c191524

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=4cc2cb3653f2f17e0cdf220eb1714c0a2d0dba30&selectedTaskRun=NBgmowhvR0-HwPjbLja2eQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=342378389&repo=autoland&lineNumber=50884

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58092e594233
Factorize the code that reads/writes memory to/from other processes r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/d747dd950198
Record the OOM allocation size in WER crashes r=KrisWright

Comment 6

[Iulian Moraru]

Backed out for causing build bustages on nsEmbedFunctions.cpp.

Push with failures

Failure log

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7f6137316ba
Factorize the code that reads/writes memory to/from other processes r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/f4c05da73b4c
Record the OOM allocation size in WER crashes r=KrisWright

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c7f6137316ba
https://hg.mozilla.org/mozilla-central/rev/f4c05da73b4c