1711480 - Remove proton doorhanger and modal pref changes from tests

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[:Gijs (he/him)]

All of these tests:

https://searchfox.org/mozilla-central/search?q=browser.proton.%2B%5C.enabled&path=test&case=false&regexp=true

At time of writing:

browser/base/content/test/tabPrompts/browser_contentOrigins.js
browser/base/content/test/tabdialogs/browser_tabdialogbox_content_prompts.js
browser/components/customizableui/test/browser_981305_separator_insertion.js
browser/components/customizableui/test/browser_proton_moreTools_panel.js
browser/components/fxmonitor/test/browser/browser_fxmonitor_doorhanger.js
browser/components/places/tests/browser/browser_bookmarksProperties.js
browser/components/places/tests/browser/head.js
toolkit/components/passwordmgr/test/browser/browser_basicAuth_multiTab.js

should stop reading and/or writing these prefs (and/or the proton.enabled pref if they use that, too).

Comment 1

[:Gijs (he/him)]

Michelle indicated she could work on this - thank you!

One bit I left out in comment 0 is that any code that turns off the prefs should be removed if it's just checking both proton-enabled and proton-disabled states. If there's some comment indicating we're turning things off because they break with proton, we should fix that instead - but off-hand I don't think any of those exist in this set of tests.

Comment 2

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1711480 - Remove proton doorhanger and modal pref changes from tests r=Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2767676bc185
Remove proton doorhanger and modal pref changes from tests r=Gijs

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2767676bc185