Closed
Bug 1711498
Opened 3 years ago
Closed 3 years ago
Remove checks for protonAppMenuEnabled or protonToolbarEnabled smart pref getters from tests
Categories
(Firefox :: Toolbars and Customization, task, P3)
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: Gijs, Assigned: masterwayz)
References
Details
(Whiteboard: [proton-cleanups])
Attachments
(1 file)
All of these checks: https://searchfox.org/mozilla-central/search?q=%5C.proton.*Enabled&path=test&case=true®exp=true
relying on PanelUI.protonAppMenuEnabled or CustomizableUI.protonToolbarEnabled should be redundant now - test code that runs only if those properties return false should be removed, test code that runs when the properties are true should no longer need to check the properties.
|
||
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Toolbars and Customization' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Component: General → Toolbars and Customization
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1766
|
||
Updated•3 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Severity: -- → N/A
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → michelle
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed by michelle@masterwayz.nl: https://hg.mozilla.org/integration/autoland/rev/03d9ad073f39 Remove checks for protonAppMenuEnabled or protonToolbarEnabled smart pref getters from tests r=Gijs
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•