1712122 - Implement Promise support in the ClipboardItem constructor

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Tom S [:evilpie]]

We currently don't support Promises in the ClipboardItem constructor like Chrome. Safari does support it and it's specified in the spec.

Before shipping we need to either implement this or change the spec, because this is apparently causing issues: bug 1619947 comment 25.

Comment 1

[Tom S [:evilpie]]

Attachment: WIP: Bug 1712122 - WIP: Implement Promise support in the ClipboardItem constructor

I am pretty sure the ref-counting and CC handling is totally wrong, because it's missing for
mPromises and mResolvedEntries.

I added mResolvedEntries because I remembered some previous discussion that MozPromise can't
hold something alive? I don't actually remember the details.

It does pass all the wpt clipboard-apis tests. However those don't include anything for Promises
in the constructor.

Comment 2

[Tom S [:evilpie]]

Hey Nika, would you mind taking a look at the CC handling etc. in the patch?

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Changing severity to N/A for enhancement

Comment 4

[Tom S [:evilpie]]

Seems like Chromium is finally working on this feature thanks to Microsoft: https://bugs.chromium.org/p/chromium/issues/detail?id=1014310.

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd0909b648d797857955575d0986a736710261ab

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1712122 - Part 2: Implement Promise support in the ClipboardItem constructor; r?nika

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=1c8eebc7e5feaf3f542e06e7e3875ece289effba

Comment 8

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=0e6f1f9fb6ac1e5b1b70fa399c9d65e85c5b415e

Comment 9

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=abac6a30029b457cea0579d711fbd3a9b6740fe3

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=86885114ad42318f6c2da2276315dd6477a9e995

Comment 11

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=b65514e71aa8afe79d2c8b60a903c7ac33412984

Comment 12

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=aa12714f6a59035fb8b21ea5ada0b2235d4661f7

Comment 13

[Edgar Chen [:edgar]]

Attachment: Bug 1712122 - Part 1: Mark some internal utility function as static; r?nika

Comment 14

[Edgar Chen [:edgar]]

Attachment: Bug 1712122 - Part 3: Cancel pending write request when a new write request is made; r?nika

The Async Clipboard API now allows using arbitrary promises for passing write data,
potentially enabling websites to delay writing data to an arbitrary future, which
may surprise the user. This patch introduces a solution: a new write request will
automatically cancel any previous pending request.

To implement that, this patch introduces a new method to nsIClipboard, new XPCOM
interfaces, and new IPC to efficiently track individual write requests. Additionally,
a new helper base class, ClipboardSetDataHelper, is introduced in widget to facilitate
platform code sharing.

Depends on D158710

Comment 15

[Edgar Chen [:edgar]]

Attachment: Bug 1712122 - Part 4: Disallow clipboard write when page is not in the active tab; r?nika

Depends on D174090

Comment 16

[Phabricator Automation]

Comment on attachment 9325955 [details]
Bug 1712122 - Part 4: Disallow clipboard write when page is not in the active tab; r?nika

Revision D174091 was moved to bug 1830340. Setting attachment 9325955 [details] to obsolete.

Comment 17

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b6ca488736491fbbdc8671b6f7a590da1ef44a15

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/079998facc02
Part 1: Mark some internal utility function as static; r=nika
https://hg.mozilla.org/integration/autoland/rev/cae91f0a02df
Part 2: Implement Promise support in the ClipboardItem constructor; r=nika
https://hg.mozilla.org/integration/autoland/rev/4d1cb082dad7
Part 3: Cancel pending write request when a new write request is made; r=nika,geckoview-reviewers,m_kato

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40005 for changes under testing/web-platform/tests

Comment 20

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/079998facc02
https://hg.mozilla.org/mozilla-central/rev/cae91f0a02df
https://hg.mozilla.org/mozilla-central/rev/4d1cb082dad7

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot