1712141 - Intermittent browser/components/extensions/test/browser/browser_ext_menus.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:680 - TypeError: can't access property "getBoundingClientRect", aTarget is null

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=340321697&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bbqPpttUTxqFBrwRA0HCsA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bbqPpttUTxqFBrwRA0HCsA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2021-05-20T14:45:19.122Z] 14:45:19     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_menus.js | Click info pageUrl is correct - 
[task 2021-05-20T14:45:19.123Z] 14:45:19     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_menus.js | Click event tab ID is correct - 
[task 2021-05-20T14:45:19.124Z] 14:45:19     INFO - Buffered messages logged at 14:45:18
[task 2021-05-20T14:45:19.125Z] 14:45:19     INFO - Console message: [JavaScript Error: "sendRemoveListener on closed conduit {535053a2-8377-41d0-a22a-4a328bc0a948}.274877907327" {file: "resource://gre/modules/ConduitsChild.jsm" line: 108}]
[task 2021-05-20T14:45:19.126Z] 14:45:19     INFO - _send@resource://gre/modules/ConduitsChild.jsm:108:13
[task 2021-05-20T14:45:19.126Z] 14:45:19     INFO - removeListener@resource://gre/modules/ExtensionChild.jsm:663:34
[task 2021-05-20T14:45:19.127Z] 14:45:19     INFO - removeListener@resource://gre/modules/ExtensionChild.jsm:886:40
[task 2021-05-20T14:45:19.127Z] 14:45:19     INFO - getAPI/register/api.menus.onClicked@chrome://browser/content/child/ext-menus.js:284:21
[task 2021-05-20T14:45:19.128Z] 14:45:19     INFO - removeListener@resource://gre/modules/ExtensionCommon.jsm:2533:7
[task 2021-05-20T14:45:19.128Z] 14:45:19     INFO - revoke@resource://gre/modules/ExtensionCommon.jsm:2555:12
[task 2021-05-20T14:45:19.128Z] 14:45:19     INFO - close@resource://gre/modules/ExtensionCommon.jsm:2560:10
[task 2021-05-20T14:45:19.129Z] 14:45:19     INFO - unload@resource://gre/modules/ExtensionCommon.jsm:922:11
[task 2021-05-20T14:45:19.130Z] 14:45:19     INFO - unload@resource://gre/modules/ExtensionPageChild.jsm:261:11
[task 2021-05-20T14:45:19.130Z] 14:45:19     INFO - unload@resource://gre/modules/ExtensionPageChild.jsm:298:11
[task 2021-05-20T14:45:19.131Z] 14:45:19     INFO - destroyExtensionContext@resource://gre/modules/ExtensionPageChild.jsm:482:15
[task 2021-05-20T14:45:19.131Z] 14:45:19     INFO - observe@resource://gre/modules/ExtensionPageChild.jsm:395:12
[task 2021-05-20T14:45:19.132Z] 14:45:19     INFO - 
[task 2021-05-20T14:45:19.132Z] 14:45:19     INFO - Leaving test bound test_actionContextMenus
[task 2021-05-20T14:45:19.133Z] 14:45:19     INFO - Entering test bound test_bookmarkContextMenu
[task 2021-05-20T14:45:19.133Z] 14:45:19     INFO - Extension loaded
[task 2021-05-20T14:45:19.136Z] 14:45:19     INFO - Console message: Warning: attempting to write 5323 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2021-05-20T14:45:19.137Z] 14:45:19     INFO - Buffered messages finished
[task 2021-05-20T14:45:19.137Z] 14:45:19     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:680 - TypeError: can't access property "getBoundingClientRect", aTarget is null```

Comment 1

[Intermittent Failures Robot]

13 failures in 3061 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10
• try: 2
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1
• linux1804-64: 9
  • opt: 9
• linux1804-64-shippable: 2
  • opt: 2
• linux1804-64-devedition: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1712141&startday=2021-05-17&endday=2021-05-23&tree=all

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1711497 only removed subtests. Could the first one have set up the environment in a way which prevented the failure before?

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #2)

Bug 1711497 only removed subtests. Could the first one have set up the environment in a way which prevented the failure before?

I checked and I don't see anything. I think that this is just a race that the removal made more likely to happen - though I can't reproduce locally on macOS, I guess all the failures are on Linux... I'm pushing a speculative fix to try. Keeping ni for now.

Comment 4

[:Gijs (out for now; he/him)]

https://treeherder.mozilla.org/jobs?repo=try&revision=c3d7976d147265ce5827a594e5833530da16e113

Comment 5

[:Gijs (out for now; he/him)]

(In reply to :Gijs (he/him) from comment #4)

https://treeherder.mozilla.org/jobs?repo=try&revision=c3d7976d147265ce5827a594e5833530da16e113

Hrmpf, that appears not to be sufficient. Tried some more: https://treeherder.mozilla.org/#/jobs?repo=try&revision=611697669be5e2d51bcd0997e7f9dadf057ee6de .

Comment 6

[:Gijs (out for now; he/him)]

Attachment: Bug 1712141 - fix intermittent browser_ext_menus.js test failures caused by bookmarks toolbar race, r?rpl

This is a bit peculiar. When we show the bookmarks toolbar, we create its children. When it then
gets hidden, they do not get removed. When we then re-enable the bookmarks toolbar, we call
rebuild on the next tick (because of the await in init in PlacesToolbarHelper), which
synchronously removes all the children of the toolbar, and then rebuilds the places node. It
does that async because it avoids doing synchronous layout falushes.

This breaks in the test - and the closer you put the "show the bookmarks toolbar" code to
the code that tries to open the context menu, the more reliably it breaks, because we try
to show the context menu right after we synchronously remove everything, and before we've
(asynchronously) put content back.

To avoid the raciness here, we wait for the custom event in the places toolbar to indicate
we're done building it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff6c0a5b384a
fix intermittent browser_ext_menus.js test failures caused by bookmarks toolbar race, r=rpl

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ff6c0a5b384a

Comment 9

[Intermittent Failures Robot]

16 failures in 2908 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 12
• mozilla-central: 2
• try: 2

Platform and build breakdown:

• linux1804-64: 8
  • opt: 8
• linux1804-64-shippable: 5
  • opt: 5
• linux1804-64-devedition: 1
  • opt: 1
• linux1804-64-asan: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1712141&startday=2021-05-24&endday=2021-05-30&tree=all