1712183 - [wpt-sync] Sync PR 27970 - Add comprehensive coverage for WindowProperties object

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27970 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27970
Details from upstream follow.

b'Alexey Shvayka <[e-mail]>' wrote:

Add comprehensive coverage for WindowProperties object

Implementation bugs

This PR tests exclusively the current spec for named properties object.

• Gecko (tested on Firefox Dev 89.0b14):

  1. [[GetOwnProperty]] doesn't return supported properties that are indices.
  2. Reflect.set and Reflect.defineProperty incorrectly throw TypeError in case of failure.
  3. [[OwnPropertyKeys]] is not an ordinary method.

• Blink (tested on Chrome 92.0.4512.0):

  1. [[DefineOwnProperty]] doesn't fail for string keys, allowing expando properties. 🎉 Now fixed! 🎉
  2. [[DefineOwnProperty]] doesn't fail for symbols.
  3. Reflect.defineProperty incorrectly returns true for string properties (supported & not).
  4. [[Get]] fails to perform named property visibility algorithm for supported indexed properties.
  5. [[Set]] doesn't fail for symbols.
  6. Reflect.set incorrectly return true for string properties (supported & not).
  7. [[Delete]] doesn't fail for symbols.

• WebKit: all passing with bug #222918.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=560f84e4b458b3fd27a926f34162f32b2bf4b5cb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 7 subtests

Status Summary

Firefox

OK : 4
PASS : 116
FAIL : 8

Chrome

OK : 4
PASS : 91
FAIL : 21

Safari

OK : 3
PASS : 14
FAIL : 8
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/WebIDL/ecmascript-binding/window-named-properties-object.html
[[HasProperty]]: FAIL
[[Get]]: FAIL
[[OwnPropertyKeys]]: FAIL

New Tests That Don't Pass

/WebIDL/ecmascript-binding/window-named-properties-object.html
[[GetOwnProperty]]: FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]]: FAIL (Chrome: FAIL, Safari: FAIL)
[[HasProperty]]: FAIL (Chrome: PASS, Safari: PASS)
[[Get]]: FAIL (Chrome: PASS, Safari: PASS)
[[Set]] (direct): FAIL (Chrome: FAIL, Safari: FAIL)
[[Delete]]: FAIL (Chrome: FAIL, Safari: FAIL)
[[OwnPropertyKeys]]: FAIL (Chrome: PASS, Safari: PASS)
/html/browsers/the-window-object/named-access-on-the-window-object/window-named-properties.html
duplicate property names: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b5961d067d9
[wpt PR 27970] - Add comprehensive coverage for WindowProperties object, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3a466c853a5d
[wpt PR 27970] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e59425afbb40
[wpt PR 27970] - Add comprehensive coverage for WindowProperties object, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e94122784bf6
[wpt PR 27970] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c27b0c23184
[wpt PR 27970] - Add comprehensive coverage for WindowProperties object, a=testonly
https://hg.mozilla.org/integration/autoland/rev/da97fe0d60e9
[wpt PR 27970] - Update wpt metadata, a=testonly

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8c27b0c23184
https://hg.mozilla.org/mozilla-central/rev/da97fe0d60e9