1712180 - Named properties object is not spec-perfect

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alexey Shvayka]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15

Steps to reproduce:

Please find detailed list of Firefox issues in WPT PR: https://github.com/web-platform-tests/wpt/pull/27970

Comment 1

[Peter Van der Beken [:peterv]]

• [[GetOwnProperty]] doesn't return supported properties that are indices.
• Reflect.set and Reflect.defineProperty incorrectly throw TypeError in case of failure.
• [[OwnPropertyKeys]] is not an ordinary method.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1712180 - Make defineProperty on the Window named properties object only throw in strict mode. r?evilpie!

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Bug 1712180 - Make GetOwnProperty on the Window named properties object return supported properties that are indices. r?evilpie!

Depends on D115637

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b870e4d668ec
Make defineProperty on the Window named properties object only throw in strict mode. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/3907d3f0c3f2
Make GetOwnProperty on the Window named properties object return supported properties that are indices. r=evilpie

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b870e4d668ec
https://hg.mozilla.org/mozilla-central/rev/3907d3f0c3f2

Comment 6

[Tom S [:evilpie]]

Seems like there is still a problem with [[OwnPropertyKeys]]: https://wpt.live/WebIDL/ecmascript-binding/window-named-properties-object.html