1712198 - Assertion failure: !IsCrossCompartmentWrapper(obj), at /builds/worker/checkouts/gecko/js/src/jsapi.cpp:1200

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Found while fuzzing m-c 20210513-9a633c33737c (--enable-debug --enable-fuzzing)

NOTE: This test case uses printPreview() which is only available in fuzzing builds.

Assertion failure: !IsCrossCompartmentWrapper(obj), at /builds/worker/checkouts/gecko/js/src/jsapi.cpp:1200

#0 0x7f80eee3f1d5 in JS::GetNonCCWObjectGlobal(JSObject*) /gecko/js/src/jsapi.cpp:1200:3
#1 0x7f80e4750e88 in xpc::WindowGlobalOrNull(JSObject*) /gecko/js/xpconnect/src/XPCJSRuntime.cpp:600:20
#2 0x7f80e59d4bc9 in nsContentUtils::IsCallerChromeOrErrorPage(JSContext*, JSObject*) /gecko/dom/base/nsContentUtils.cpp:2138:30
#3 0x7f80e733c7b7 in mozilla::dom::FocusOptions::Init(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, char const*, bool) /builds/worker/workspace/obj-build/dom/bindings/ElementBinding.cpp:150:9
#4 0x7f80e75fd7e6 in mozilla::dom::HTMLElement_Binding::focus(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/HTMLElementBinding.cpp:9233:13
#5 0x7f80e780c599 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /gecko/dom/bindings/BindingUtils.cpp:3297:13
#6 0x7f80ee5e1d32 in CallJSNative /gecko/js/src/vm/Interpreter.cpp:427:13
#7 0x7f80ee5e1d32 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /gecko/js/src/vm/Interpreter.cpp:512:12
#8 0x7f80ee5e3a6b in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /gecko/js/src/vm/Interpreter.cpp:589:8
#9 0x7f80ee7c0b79 in js::ForwardingProxyHandler::call(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) const /gecko/js/src/proxy/Wrapper.cpp:165:10
#10 0x7f80ee76a186 in js::CrossCompartmentWrapper::call(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) const /gecko/js/src/proxy/CrossCompartmentWrapper.cpp:227:19
#11 0x7f80ee7a74b6 in js::Proxy::call(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) /gecko/js/src/proxy/Proxy.cpp:656:19
#12 0x7f80ee5e233c in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /gecko/js/src/vm/Interpreter.cpp:492:14
#13 0x7f80ee5c94d5 in CallFromStack /gecko/js/src/vm/Interpreter.cpp:576:10
#14 0x7f80ee5c94d5 in Interpret(JSContext*, js::RunState&) /gecko/js/src/vm/Interpreter.cpp:3227:16
#15 0x7f80ee5b2b46 in js::RunScript(JSContext*, js::RunState&) /gecko/js/src/vm/Interpreter.cpp:396:13
#16 0x7f80ee5e1e6b in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /gecko/js/src/vm/Interpreter.cpp:544:13
#17 0x7f80ee5e3a6b in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /gecko/js/src/vm/Interpreter.cpp:589:8
#18 0x7f80eee4ca52 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /gecko/js/src/jsapi.cpp:2796:10
#19 0x7f80e734b799 in mozilla::dom::EventListener::HandleEvent(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/EventListenerBinding.cpp:58:8
#20 0x7f80e7fbaf78 in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/obj-build/dist/include/mozilla/dom/EventListenerBinding.h:65:12
#21 0x7f80e7fbaa70 in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /gecko/dom/events/EventListenerManager.cpp:1108:43
#22 0x7f80e7fbc097 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /gecko/dom/events/EventListenerManager.cpp:1305:17
#23 0x7f80e7fa93fe in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /gecko/dom/events/EventDispatcher.cpp:354:17
#24 0x7f80e7fa7c21 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /gecko/dom/events/EventDispatcher.cpp:556:16
#25 0x7f80e7fac004 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /gecko/dom/events/EventDispatcher.cpp:1110:11
#26 0x7f80e7fb1aa9 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) /gecko/dom/events/EventDispatcher.cpp
#27 0x7f80e5f0c3ca in nsINode::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&) /gecko/dom/base/nsINode.cpp:1331:17
#28 0x7f80e59e4daf in nsContentUtils::DispatchEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, mozilla::Trusted, bool*, mozilla::ChromeOnlyDispatch) /gecko/dom/base/nsContentUtils.cpp:4315:28
#29 0x7f80e59e4af3 in nsContentUtils::DispatchTrustedEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, bool*) /gecko/dom/base/nsContentUtils.cpp:4285:10
#30 0x7f80e5c60a76 in mozilla::dom::Document::DispatchContentLoadedEvents() /gecko/dom/base/Document.cpp:7663:3
#31 0x7f80e5d1ec5f in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1150:12
#32 0x7f80e5d1ec5f in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1156:12
#33 0x7f80e5d1ec5f in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1203:13
#34 0x7f80e28b6ecf in mozilla::SchedulerGroup::Runnable::Run() /gecko/xpcom/threads/SchedulerGroup.cpp:143:20
#35 0x7f80e28fab22 in mozilla::RunnableTask::Run() /gecko/xpcom/threads/TaskController.cpp:482:16
#36 0x7f80e28c75b0 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /gecko/xpcom/threads/TaskController.cpp:766:26
#37 0x7f80e28c50b7 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /gecko/xpcom/threads/TaskController.cpp:621:15
#38 0x7f80e28c550d in mozilla::TaskController::ProcessPendingMTTask(bool) /gecko/xpcom/threads/TaskController.cpp:405:36
#39 0x7f80e2904b51 in operator() /gecko/xpcom/threads/TaskController.cpp:138:37
#40 0x7f80e2904b51 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() /gecko/xpcom/threads/nsThreadUtils.h:534:5
#41 0x7f80e28e1e98 in nsThread::ProcessNextEvent(bool, bool*) /gecko/xpcom/threads/nsThread.cpp:1159:16
#42 0x7f80e28ecc4c in NS_ProcessNextEvent(nsIThread*, bool) /gecko/xpcom/threads/nsThreadUtils.cpp:548:10
#43 0x7f80e3a9be8f in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /gecko/ipc/glue/MessagePump.cpp:85:21
#44 0x7f80e39a40c1 in RunInternal /gecko/ipc/chromium/src/base/message_loop.cc:335:10
#45 0x7f80e39a40c1 in RunHandler /gecko/ipc/chromium/src/base/message_loop.cc:328:3
#46 0x7f80e39a40c1 in MessageLoop::Run() /gecko/ipc/chromium/src/base/message_loop.cc:310:3
#47 0x7f80ea13e6c7 in nsBaseAppShell::Run() /gecko/widget/nsBaseAppShell.cpp:137:27
#48 0x7f80ee39019f in XRE_RunAppShell() /gecko/toolkit/xre/nsEmbedFunctions.cpp:911:20
#49 0x7f80e39a40c1 in RunInternal /gecko/ipc/chromium/src/base/message_loop.cc:335:10
#50 0x7f80e39a40c1 in RunHandler /gecko/ipc/chromium/src/base/message_loop.cc:328:3
#51 0x7f80e39a40c1 in MessageLoop::Run() /gecko/ipc/chromium/src/base/message_loop.cc:310:3
#52 0x7f80ee38fb78 in XRE_InitChildProcess(int, char**, XREChildData const*) /gecko/toolkit/xre/nsEmbedFunctions.cpp:743:34
#53 0x55aaad78861d in content_process_main(mozilla::Bootstrap*, int, char**) /gecko/browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
#54 0x55aaad788a4d in main /gecko/browser/app/nsBrowserApp.cpp:313:18
#55 0x7f8103f410b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
#56 0x55aaad6d9919 in _start (/home/worker/builds/m-c-20210516091748-fuzzing-asan-opt/firefox+0x5b919)

Comment 1

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/S7njC0U04KHUgcELSo2aYw/index.html

Comment 2

[Andrew McCreight [:mccr8]]

Looking at the stack, I think this is a regression from bug 1710756.

Comment 3

[Bugmon [:jkratzer for issues]]

Bugmon Analysis:
Verified bug as reproducible on mozilla-central 20210520095745-45c659bd4922.
The bug appears to have been introduced in the following build range:

Start: 02ea24efbd7c484246b2a9aa161c0b8bb1cb56e6 (20210512104658)
End: 95d93c007301f5a90edf1e8f79641f7c7569ba68 (20210512174859)
Pushlog: https://hg.mozilla.org/mozilla-unified/pushloghtml?fromchange=02ea24efbd7c484246b2a9aa161c0b8bb1cb56e6&tochange=95d93c007301f5a90edf1e8f79641f7c7569ba68

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1712198 - Unwrap object in IsCallerChromeOrErrorPage. r=mccr8,edgar

This is what e.g. our use counter setup does:

https://searchfox.org/mozilla-central/rev/6e630edb09c3ab06d0103665b16c9ea7dce782c5/dom/bindings/BindingUtils.cpp#4037

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1710756

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac170743db6e
Unwrap object in IsCallerChromeOrErrorPage. r=edgar

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ac170743db6e

Comment 8

[Bugmon [:jkratzer for issues]]

Bugmon Analysis:
Verified bug as fixed on rev mozilla-central 20210526094846-0b451a88f161.
Removing bugmon keyword as no further action possible.
Please review the bug and re-add the keyword for further analysis.