Closed Bug 1712215 Opened 8 months ago Closed 7 months ago

Update drop shadows on all card elements

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
91 Branch
Tracking Status
firefox91 --- verified

People

(Reporter: amy, Assigned: amy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

For both dark and light themes we should update the drop shadow values for cards.

Dark theme:

box-shadow: 0px 2px 6px rgba(28, 27, 34, 0.5);

Light theme:

box-shadow: 0px 2px 6px rgba(58, 57, 68, 0.2);
Blocks: 1712221
No longer blocks: 1712221
No longer depends on: 1711113
Assignee: nobody → achurchwell
Attachment #9223662 - Attachment description: Bug 1712215, 1712221 - Update drop shadows. r?dao → Bug 1712215, 1712221 - Update drop shadows. r?dao, thecount
Attachment #9223662 - Attachment description: Bug 1712215, 1712221 - Update drop shadows. r?dao, thecount → Bug 1712215, 1712221 - Update drop shadows. r?dao
Attachment #9223662 - Attachment description: Bug 1712215, 1712221 - Update drop shadows. r?dao → Bug 1712215, 1712221 - Update drop shadows. r?thecount
Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7a108e738ee
1712221 - Update drop shadows. r=thecount

Backed out for failures on browser_parsable_css.js

backout: https://hg.mozilla.org/integration/autoland/rev/ce417ca70192e63966217101a454604ecb53f269

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Yn1NisF6STmpl9RReFPp6Q.0&revision=f7a108e738eedbb97eb84f28bffa518e1c7484a6

failure log: https://treeherder.mozilla.org/logviewer?job_id=342301361&repo=autoland&lineNumber=1937

[task 2021-06-09T20:09:05.066Z] 20:09:05     INFO - Console message: [JavaScript Warning: "Expected media feature name but found -moz-windows-default-theme." {file: "jar:file:///Z:/task_1623268367/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/skin/autocomplete-item.css?always-parse-css-0.9184688623843175" line: 12}]
[task 2021-06-09T20:09:05.067Z] 20:09:05     INFO - Console message: [JavaScript Warning: "Unknown property -moz-context-properties.  Declaration dropped." {file: "jar:file:///Z:/task_1623268367/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/manageDialog.css?always-parse-css-0.9184688623843175" line: 73}]
[task 2021-06-09T20:09:05.068Z] 20:09:05     INFO - Console message: [JavaScript Warning: "Unknown property -moz-context-properties.  Declaration dropped." {file: "jar:file:///Z:/task_1623268367/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/formautofill.css?always-parse-css-0.9184688623843175" line: 43}]
[task 2021-06-09T20:09:05.068Z] 20:09:05     INFO - Buffered messages finished
[task 2021-06-09T20:09:05.069Z] 20:09:05     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--newtab-inner-box-shadow-color-nte` is not referenced - 
[task 2021-06-09T20:09:05.069Z] 20:09:05     INFO - Stack trace:
[task 2021-06-09T20:09:05.069Z] 20:09:05     INFO - chrome://mochikit/content/browser-test.js:test_ok:1334
[task 2021-06-09T20:09:05.069Z] 20:09:05     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:460
[task 2021-06-09T20:09:05.069Z] 20:09:05     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-06-09T20:09:05.070Z] 20:09:05     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--newtab-tile-shadow-secondary` is not referenced - 
[task 2021-06-09T20:09:05.070Z] 20:09:05     INFO - Stack trace:
[task 2021-06-09T20:09:05.070Z] 20:09:05     INFO - chrome://mochikit/content/browser-test.js:test_ok:1334
[task 2021-06-09T20:09:05.070Z] 20:09:05     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:460
[task 2021-06-09T20:09:05.070Z] 20:09:05     INFO - Not taking screenshot here: see the one that was previously logged
Flags: needinfo?(achurchwell)
Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd611a00944c
1712221 - Update drop shadows. r=thecount
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: needinfo?(achurchwell)
Regressions: 1718312

I have verified this issue using Firefox Nightly 91.0a1 (Build ID: 20210707215219) on Windows 10 x64, macOS 11.4, and Ubuntu Linux 20.04.

The observed values are as follows:

  • For the "Recommended by Pocket" cards:
    • For dark theme, the box-shadow value is 0 2px 6px rgba(28, 27, 34, 0.5);
    • For light theme, the box-shadow value is 0 2px 6px rgba(58, 57, 68, 0.2);
    • For Firefox Alpenglow dark variant, the box-shadow value is 0 2px 6px rgba(28, 27, 34, 0.5);
    • For Firefox Alpenglow light variant, the box-shadow value is 0 2px 6px rgba(58, 57, 68, 0.2);
  • For the "Recent activity" cards:
    • For dark theme, the box-shadow value is 0 2px 6px rgba(28, 27, 34, 0.5);
    • For light theme, the box-shadow value is 0 2px 6px rgba(58, 57, 68, 0.2);
    • For Firefox Alpenglow dark variant, the box-shadow value is 0 2px 6px rgba(28, 27, 34, 0.5);
    • For Firefox Alpenglow light variant, the box-shadow value is 0 2px 6px rgba(58, 57, 68, 0.2);
Status: RESOLVED → VERIFIED
Regressions: 1732405
No longer regressions: 1732405
You need to log in before you can comment on or make changes to this bug.