1712219 - Uncommon download type should have information badge on downloads button

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Emma Malysz]

For an uncommon download, we currently surface the warning icon for the download's button badge https://searchfox.org/mozilla-central/rev/2f1a015b004b79f1145c81cdf86b15481a5630e2/browser/components/downloads/DownloadsCommon.jsm#1388,1392-1394, but in the downloads panel, we show the information icon.

These should be consistent. We should change this to the blue information badge detailed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1709717#c0

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This can be tested at http://testsafebrowsing.appspot.com/, we indeed show the warning badge on the downloads button... and it's actually looking a bit strange during the animation because it's behind it, maybe it should be hidden during the animation?
And then as you said we show the info icon. I'll attach a couple screenshots to show it.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: this is the panel with the info icon

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Badge crossing the animation

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Sam, were badges considered for the animation? Is there any spec about these?

Comment 5

[Sam Foster [:sfoster] (he/him)]

:KatieC, Amy directed me back to you to answer this. Currently, when the download button has a badge, the animation plays on top of it and it doesnt look great. The button could also acquire a badge as a result of the current download. Do you have thoughts on how we should handle this?

Comment 6

[Sam Foster [:sfoster] (he/him)]

I thought we had an existing bug on file about the animation playing on top (rather than underneath) the badge, but I'm unable to find it now.

Comment 7

[Sam Foster [:sfoster] (he/him)]

I propose p2 for this, please change if you disagree

Comment 8

[katieC]

The badges were not considered as part of the animation and were missed during scoping of the downloads panel + animation work. Downloads panel UX review is part of MR1.1 work. (I'm adding this bug to our UX review list, will inform PMs, and will leave my NI for now.)

Comment 9

[:Gijs (he/him)]

Tentatively assigning some points but we should adjust based on the final design considerations.

Comment 10

[katieC]

Moving my NI to Janice.

Comment 11

[Janice Cramer]

1. Confirming that the icon badge for "uncommon downloads" should match the information icon within the downloads panel. This is the original reason that Emma filed this bug.
2. Regarding the animation playing over the badge—the badge should appear after the animation completes. This addresses Marco and Sam's concern.
3. When the user clicks the icon to open the downloads panel, the icon badge should clear.

Comment 12

[katieC]

Attachment: Toolbar Badges : mini UX spec

Gijs mentioned positioning of the badges on the download icon. Here's a mini spec from the MR1 work.

Comment 13

[Molly Howell (she/her) (no longer active)]

(In reply to Janice Cramer from comment #11)

1. Confirming that the icon badge for "uncommon downloads" should match the information icon within the downloads panel. This is the original reason that Emma filed this bug.
2. Regarding the animation playing over the badge—the badge should appear after the animation completes. This addresses Marco and Sam's concern.
3. When the user clicks the icon to open the downloads panel, the icon badge should clear.

To summarize what I'm doing here: I've just gotten a patch ready that addresses #1 by adding an "info" badge case for the uncommon download status, and also addresses #2 by hiding the badge (of any type) while the animation is playing, but #3 appears to already be the behavior that we have, so I don't intend to change anything around that.

Comment 14

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1712219 - Downloads toolbar button badge behavior improvements.

This patch addresses two points where the badge on the download status toolbar
button's badge was not quite meeting the MR1 design spec:

1. The badge for the "uncommon download" safe browsing verdict should be "info"
   (currently a blue circle) and not "warning" (a yellow triangle).
2. The badge (regardless of its type) should not appear while the "finished"
   animation is playing, only after it completes.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d334373c35b8
Downloads toolbar button badge behavior improvements. r=Gijs

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d334373c35b8

Comment 17

[Monica Chiorean]

I was able to reproduce issue 1 and 2 on 90.0a1 (20210520095745) and verified as fixed on Windows 10, Ubuntu 20.4 and Mac 10.13 using Build 95.0 (20211129150630).