Add boolean text before each search term

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
15 years ago
10 years ago

People

(Reporter: Scott MacGregor, Assigned: Scott MacGregor)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

47.01 KB, image/jpeg
Details
5.27 KB, patch
Sean Su
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
I noticed in a recent spec from Jennifer that she was putting text just before
search terms in search dialogs (Filter, Search and create mail view dialogs to
be precise).

Her spec had text like
"or the"
or
"and the"
before the search term. Each row of search terms had this text in it. 

It's trivial to add this into the product so I just did so to match her specs. 

Attaching screen shots. 

Jennifer, let me know if this is something you are indeed interested in adding
to the product and we'll check this in.
(Assignee)

Comment 1

15 years ago
Created attachment 100899 [details]
screen shot of search dialog with the new text
(Assignee)

Comment 2

15 years ago
Created attachment 100900 [details] [diff] [review]
the fix

Comment 3

15 years ago
There's been some debate in the past over whether such text should be there or
not (whether is there or not should apply to filters as well as search, I
think).  Will have to look up the older bugs, but the text used to be there then
wasn't and was left out, so we also have a bug to remove the space that used to
be/now would be occupied by such text. 

Comment 4

15 years ago
Two related bugs I found: bug 40356 and bug 82015.  Seems to me there might also
be another judging from the numbers of the above bugs and their chronological
order relative to the issue...

Comment 5

15 years ago
i remember contributing this fix years ago, and then at some point it was
removed, it's good to see we're ~running round in circles~.

Comment 6

15 years ago
bug 40365 was changed from "Filter/Search UI: criteria AND/OR column display is 
not correct" to "Filter/Search UI: remove space between criteria columns" when 
it was though that we couldn't consistently display the  And/Or text correctly. 
See comment:
http://bugzilla.mozilla.org/show_bug.cgi?id=40356#c12

bug 82015 is: "Search/Filters UI: AND/OR text not always appearing until AND/OR 
toggled". See comment: http://bugzilla.mozilla.org/show_bug.cgi?id=82015#c9

If we can get And/Or to Consistently work Correctly, I think it is valuable to 
have the additional text. It makes it clear that All=And and Any=Or.

Comment 7

15 years ago
>bug 40365 was changed from...
Sorry, bug 40356
(Assignee)

Comment 8

15 years ago
I believe this patch makes it show up and work consistently. In the past this
widget was a tree and it was harder to get this to work. Sounds like this is
something we have UI approval for so I'll drive it in. 

Updated

15 years ago
Attachment #100900 - Flags: review+

Comment 9

15 years ago
Comment on attachment 100900 [details] [diff] [review]
the fix

r=ssu
Comment on attachment 100900 [details] [diff] [review]
the fix

sr=sspitzer, assuming msg search and msg filter look ok.

does your fix affect the advanced address search dialog?  if not, feel free to
log a bug on me to fix it to look / behave the same as the msg search dialog.
Attachment #100900 - Flags: superreview+
(Assignee)

Comment 11

15 years ago
fix checked in. 
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 12

15 years ago
OK using oct14 commercial trunk: win98, mac OS 10.1, linux rh6.2
Checked in Modern and Classic, Filter Rules and Search Messages.
Status: RESOLVED → VERIFIED

Comment 13

15 years ago
Oh, yeah, forgot about Search Addresses... looks OK there, too.
Product: Browser → Seamonkey

Updated

10 years ago
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.