1712382 - `./mach clobber python` should remove virtualenvs

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Description

[Mitchell Hentges [:mhentges] 🦀]

It's called ./mach clobber python, but it only deletes pyc files. Other python-related generated files (such as _virtualenvs) aren't deleted.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1712382: Includes virtualenvs when clobbering Python

We no longer build and install native Python modules in
third_party/python, so purging that doesn't make sense anymore.

After that, all that's being purged is py[cdo] files and their parent
__pycache__ directories.

Also leans into argparse's choices argument, which should make
command migrations easier for consumers: "invalid choice: 'python'
(choose from 'gradle', 'pyc', 'objdir')".

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1712382: Remove "setup.py" action support from virtualenvs

The setup.py action is no longer used, so we can safely remove it.

Depends on D115641

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1712382: Remove "set-variable" action support from virtualenvs

MACH_VIRTUALENV was never used, and MOZBUILD_VIRTUALENV was never
set (the virtualenv was always activated during the build, rather
than before).

Depends on D115913

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1712382: `./mach clobber gradle` works if directory already gone

Back-to-back ./mach clobber gradle invocations were failing
because shutil.rmtree(..) would complain that the target directory
didn't exist.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/922cb1e35a9e
Remove "setup.py" action support from virtualenvs r=ahal
https://hg.mozilla.org/integration/autoland/rev/05c9e4f016fd
Remove "set-variable" action support from virtualenvs r=ahal

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1bda584266e
Includes virtualenvs when clobbering Python r=glandium
https://hg.mozilla.org/integration/autoland/rev/9e0875e5c029
`./mach clobber gradle` works if directory already gone r=nalexander

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/922cb1e35a9e
https://hg.mozilla.org/mozilla-central/rev/05c9e4f016fd
https://hg.mozilla.org/mozilla-central/rev/c1bda584266e
https://hg.mozilla.org/mozilla-central/rev/9e0875e5c029