1720113 - `./mach clobber` doesn't clobber the objdir hard enough

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jonathan Kew [:jfkthame]]

In particular, ./mach clobber doesn't blow away _virtualenvs, and this can result in a mysteriously broken build.

In my case, I was getting Glean-related build failures even after clobbering, because there was an outdated glean_parser cached in the objdir's _virtualenvs. It took entirely too long to figure out that clobber wasn't enough and I needed to manually rm -rf' the entire objdir to get a successful build again.

Comment 1

[Jonathan Kew [:jfkthame]]

(Bug 1645889 sounds like it should have taken care of this, but I've just been experiencing the pain on current trunk.)

Comment 2

[Jonathan Kew [:jfkthame]]

I see this changed in c1bda584266e (bug 1712382) -- prior to that, ./mach clobber did delete the _virtualenvs directory in the objdir.

I think it would be better if ./mach clobber continues to include the functionality of ./mach clobber python (as per bug 1645889); the default behavior here should be the simple thing that works all the time. More sophisticated users may want to be able to "clobber" individual categories of things, but ./mach clobber should be the command that "just works" without requiring a detailed understanding of what the local breakage happens to be.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

This was caused by this patch, where I assumed that virtualenv stability was stronger than it is. Fortunately, they will be made more resilient (recover incomplete venvs, automatically update venvs when requirements change) in the next few months.

However, since that stability is still a ways away, I'll temporarily adjust clobber to purge virtualenvs still.
Thanks for the report!

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1720113: Temporarily add "python" to default clobber set

Until virtualenvs are more dependably consistent, we should purge them
by default when "./mach clobber" is run.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d3866600b1c
Temporarily add "python" to default clobber set r=firefox-build-system-reviewers,nalexander

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7d3866600b1c

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1712382

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mhentges, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.