Closed Bug 1712498 Opened 4 years ago Closed 4 years ago

Use SeaMonkey's configured web search rather than separate one

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.9)

Attachments

(1 file, 1 obsolete file)

At the moment chatZilla has its own pref websearch.url which it uses if set instead of the one set in SeaMonkey. We should just use the SeaMonkey one.

Attached patch 1712498-irc-websearch-2539.patch (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: separate web search configuration
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 string removals

Attachment #9223125 - Flags: review?(frgrahl)
Attachment #9223125 - Flags: approval-comm-release?
Attachment #9223125 - Flags: approval-comm-esr60?

Changes since last version:

  • Makes use of browser.search.opentabforcontextsearch pref to determine whether to open as a tab or window.
Attachment #9223125 - Attachment is obsolete: true
Attachment #9223125 - Flags: review?(frgrahl)
Attachment #9223125 - Flags: approval-comm-release?
Attachment #9223125 - Flags: approval-comm-esr60?
Attachment #9224134 - Flags: review?(frgrahl)
Attachment #9224134 - Flags: approval-comm-release?
Attachment #9224134 - Flags: approval-comm-esr60?
Blocks: 1713458

Comment on attachment 9224134 [details] [diff] [review]
1712498-irc-websearch-v1_1-2539.patch

LGTM

Attachment #9224134 - Flags: review?(frgrahl)
Attachment #9224134 - Flags: review+
Attachment #9224134 - Flags: approval-comm-release?
Attachment #9224134 - Flags: approval-comm-release+
Attachment #9224134 - Flags: approval-comm-esr60?
Attachment #9224134 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2f5ee8b527d9
Use SeaMonkey's configured web search rather than separate one. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.9
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: