1713458 - Allow shiftKey to modify behaviour of link clicking in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

As mentioned in Bug 1619108, at the moment chatZilla ignores the shift key when clicking on links within the chat window. Whilst we're here:

• remove the now unused goto-url-external code
• remove unused call to openTopWin
• switch from openUILinkIn to openLinkIn to avoid fromChrome flag
• remove cZ link.focus pref as it is overridden by the browser.tabs.loadInBackground pref

Comment 1

[Ian Neal]

Attachment: 1713458-irc-goto-url-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: inconsistent behaviour when clicking on links
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 5 strings removed

Comment 2

[Ian Neal]

Attachment: 1713458-irc-goto-url-v1_1-2539.patch

Refreshed against the wrong patch so missing one change.

Comment 3

[Ian Neal]

Attachment: 1713458-irc-goto-url-v1_2-2539.patch

Also allow use of the shift key when doing web searches.

Comment 4

[Dmitry Butskoy (:buc)]

When ((action == "goto-url-newtab") && !browserWin),
which statement finally takes an effect: where = "window"; or where = e.shiftKey ? "tabshifted" : "tab";?

Comment 5

[Ian Neal]

Attachment: 1713458-irc-goto-url-v1_3-2539.patch

Well spotted buc.
Let openLinkIn function do more of the logic around whether we need to open a window or tab rather than trying to do it twice.

Comment 6

[Ian Neal]

Attachment: 1713458-irc-goto-url-v1_4-2539.patch

Changes since last patch:

• Add back link focus pref and make use of it to decide whether to bring browser window into focus

Comment 7

[Ian Neal]

Comment on attachment 9224263 [details] [diff] [review]
1713458-irc-goto-url-v1_3-2539.patch

This version goes alongside patch version 1.1 on Bug 1720003

Comment 8

[Ian Neal]

Attachment: 1713458-irc-goto-url-v1_5-2539.patch

Changes since v1.3:

• Make use of browser.tabs.loadDivertedInBackground pref to determine whether link should be loaded in background or not.

Comment 9

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9230803 [details] [diff] [review]
1713458-irc-goto-url-v1_5-2539.patch

LGTM

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f38788ac1ce8
Allow shiftKey to modify behaviour of link clicking in cZ. r=frg

Comment 11

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b92b7b163bd4e8875557263692b8ba17706b8cec
Allow shiftKey to modify behaviour of link clicking in cZ. r=frg a=frg