1712628 - mark taskbar pinning methods as unsupported in msix builds

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

nsWindowsShellService.isCurrentAppPinnedToTaskbarAsync() currently relies on matching paths in the shortcut. This does not work for a packaged app. The UWP API TaskbarManager.IsCurrentAppPinnedAsync is the way to handle this for a packaged app.

I have a rough WIP, from trying to get RequestPinCurrentAppAsync working. It would need to be in addition to the existing implementation since this is only available from within a package.

This would only really be of use for telemetry. Aside: os.environment.launch_method is always Other when launching a package, whether it was opened from a taskbar pin, start menu shortcut, or desktop shortcut; there must be some amount of indirection so that we don't know the shortcut that opened us.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1712628: mark taskbar pinning methods as not implemented for MSIX packages r?nalexander

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab394fa4b59b
mark taskbar pinning methods as not implemented for MSIX packages r=nalexander

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ab394fa4b59b

Comment 4

[[e-mail] (:bhearsum)]

Re-opening because the landed patch is just preventing us from lying about supporting pinning in MSIX - not actually implementing it.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to [e-mail] (:bhearsum) from comment #4)

Re-opening because the landed patch is just preventing us from lying about supporting pinning in MSIX - not actually implementing it.

I was reminded recently that we are strongly discouraged from adding additional patches onto fixed bugs because it messes up tracking flags and various queries. For that reason, I re-filed this as https://bugzilla.mozilla.org/show_bug.cgi?id=1794159 for the actual implementation.